Skip to content

fix(global): relative windows --paths#4395

Merged
Hofer-Julian merged 3 commits intoprefix-dev:mainfrom
baszalmstra:feature/pxi-125-fix-recursive_source_deps-for-pixi-global-on-windows
Aug 19, 2025
Merged

fix(global): relative windows --paths#4395
Hofer-Julian merged 3 commits intoprefix-dev:mainfrom
baszalmstra:feature/pxi-125-fix-recursive_source_deps-for-pixi-global-on-windows

Conversation

@baszalmstra
Copy link
Contributor

When installing a package from source globally with pixi global install --path <path>, the path is made relative to the global manifest and converted to a Utf8TypedPathBuf. However, on windows this relative path contains backslashes (\). When converting from a string back to a Utf8TypedPathBuf the path is parsed as a unix path and thus the \s are ignored and considered to be part of the directory name.

This PR changes this behavior to convert the path to the "native" path type, which then correctly splits the path at backslashes, allowing relative packages to be properly resolved.

This fixes the test in prefix-dev/pixi-build-testsuite#43

Copy link
Contributor

@Hofer-Julian Hofer-Julian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Hofer-Julian Hofer-Julian enabled auto-merge (squash) August 19, 2025 14:21
@Hofer-Julian Hofer-Julian merged commit e2a671e into prefix-dev:main Aug 19, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants