Skip to content

chore: improve download robustness in install.sh#3451

Merged
ruben-arts merged 3 commits intoprefix-dev:mainfrom
gzm55:work/improve-installer
Apr 29, 2025
Merged

chore: improve download robustness in install.sh#3451
ruben-arts merged 3 commits intoprefix-dev:mainfrom
gzm55:work/improve-installer

Conversation

@gzm55
Copy link
Copy Markdown
Contributor

@gzm55 gzm55 commented Mar 28, 2025

improve downloading robost

  1. detect buggy curl before using
  2. when curl downloads fail due to local ssl error (e.g. old nss package), fallback wget to try download again
  3. avoid depending on head and cut commands

@ruben-arts
Copy link
Copy Markdown
Contributor

This is a lot of change to a very important script without any tests, could you either split it up or show tests of the new features?

@gzm55
Copy link
Copy Markdown
Contributor Author

gzm55 commented Mar 28, 2025

This is a lot of change to a very important script without any tests, could you either split it up or show tests of the new features?

ok, 1 and 4 are trivial and will be split to another pr;
2 and 3 can be put together. The fallback logic occur on curl 8.0 or systems with old nss package. so it can be tested via a mock curl.

@ruben-arts
Copy link
Copy Markdown
Contributor

If you could write a small github action workflow to test these scripts that would be extremely helpful.

@gzm55
Copy link
Copy Markdown
Contributor Author

gzm55 commented Mar 28, 2025

If you could write a small github action workflow to test these scripts that would be extremely helpful.

is there test cases about installer now?

@gzm55 gzm55 force-pushed the work/improve-installer branch from 5e75318 to dd05172 Compare April 16, 2025 10:09
@gzm55 gzm55 changed the title chore: some improvement on install.sh chore: improve download robustness in install.sh Apr 17, 2025
@gzm55 gzm55 marked this pull request as ready for review April 17, 2025 01:41
@gzm55
Copy link
Copy Markdown
Contributor Author

gzm55 commented Apr 17, 2025

@ruben-arts @baszalmstra

This PR is now ready for review and focuses on enhancing download tool selection and improving error recovery.

Copy link
Copy Markdown
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appart from the curl 8.8.0 which was to hard to test for me this seems to work great!

Copy link
Copy Markdown
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appart from the curl 8.8.0 which was to hard to test for me this seems to work great!

@ruben-arts ruben-arts merged commit 231108b into prefix-dev:main Apr 29, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants