feat: install.sh supports installing without tar and unzip commands#3551
Merged
Hofer-Julian merged 8 commits intoprefix-dev:mainfrom Apr 16, 2025
Merged
feat: install.sh supports installing without tar and unzip commands#3551Hofer-Julian merged 8 commits intoprefix-dev:mainfrom
Hofer-Julian merged 8 commits intoprefix-dev:mainfrom
Conversation
Contributor
|
Thanks for that @gzm55. Could you please solve the merge conflicts now that we merged your shell format PR? |
Contributor
Author
resolved. |
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Files not reviewed (1)
- install/install.sh: Language not supported
Comments suppressed due to low confidence (2)
.github/workflows/ci.yml:829
- Before renaming tar, check if the command exists to prevent errors in environments where tar may already be absent.
mv $(which tar) $(which tar).bak
.github/workflows/ci.yml:872
- Consider simulating the absence of unzip (for example, by renaming it) in the msys2 test to fully validate the new feature behavior.
sh < ./install/install.sh
gzm55
changed the title
Hofer-Julian
reviewed
Apr 9, 2025
Contributor
Hofer-Julian
left a comment
Hofer-Julian
left a comment
There was a problem hiding this comment.
Two small comments, after that it seems good to go to me!
Co-authored-by: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tarandunzipis not found, download the uncompressed executable directly.install.sh#3451)install.sh#3451)