fix: check unzip command on msys and add ITs for install.sh#3458
Merged
Hofer-Julian merged 7 commits intoprefix-dev:mainfrom Apr 8, 2025
Merged
fix: check unzip command on msys and add ITs for install.sh#3458Hofer-Julian merged 7 commits intoprefix-dev:mainfrom
Hofer-Julian merged 7 commits intoprefix-dev:mainfrom
Conversation
Contributor
Author
|
@ruben-arts ci integration test for installer and some small fixes are here. |
gzm55
changed the title
Contributor
Author
@ruben-arts does any other one can review this pr? |
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Files not reviewed (1)
- install/install.sh: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:792
- Using input redirection with 'sh < ./install/install.sh' may not correctly execute the script in all environments. Consider executing it directly as 'sh ./install/install.sh' to ensure consistent behavior.
sh < ./install/install.sh
Hofer-Julian
approved these changes
Apr 8, 2025
Contributor
Hofer-Julian
left a comment
Hofer-Julian
left a comment
There was a problem hiding this comment.
Nice improvement @gzm55! Thank you for your contribution!
prsabahrami
pushed a commit
that referenced
this pull request
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
install.sh#3451