Ensure that a state settled hook cant interfere with a signal update #696
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should set
component.__fin Preact again to make sure we hit the branch, this ensures that the new state settling logic as seen in preactjs/preact#4760 can cooperate with signals.The issue is when we dispatch 3 updates
This would result in
_afterRendersetting SKIP_CHILDREN for the hook but the signal wants to rightfully update.