Skip to content

Conversation

@JoviDeCroock
Copy link
Member

We've collectively decided to undo the unsafe and state settling changes because this was leading to some unexpected ecosystem changes.

@JoviDeCroock JoviDeCroock requested a review from rschristian July 6, 2025 08:55
@github-actions
Copy link

github-actions bot commented Jul 6, 2025

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +1% (-11.79ms - +9.48ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +0% (-0.19ms - +0.03ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +3% (-1.04ms - +1.87ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -2% - +1% (-0.41ms - +0.13ms)
    preact-local vs preact-main
  • replace1k: slower ❌ 0% - 3% (0.09ms - 1.97ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -5% - +3% (-0.10ms - +0.07ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +1% (-0.10ms - +0.31ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -4% - +4% (-1.16ms - +1.13ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - -0% (-0.01ms - -0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +12% (-0.11ms - +0.72ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - -0% (-0.01ms - -0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -4% - +2% (-0.04ms - +0.02ms)
    preact-local vs preact-main
  • todo: faster ✔ 0% - 1% (0.00ms - 0.01ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local972.28ms - 987.19ms-unsure 🔍
-1% - +1%
-11.79ms - +9.48ms
preact-main973.31ms - 988.48msunsure 🔍
-1% - +1%
-9.48ms - +11.79ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.18ms - 19.18ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main19.19ms - 19.19msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.48ms - 16.54ms-unsure 🔍
-1% - +0%
-0.19ms - +0.03ms
preact-main16.48ms - 16.70msunsure 🔍
-0% - +1%
-0.03ms - +0.19ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.53ms - 1.54ms-unsure 🔍
-0% - -0%
-0.01ms - -0.00ms
preact-main1.54ms - 1.54msunsure 🔍
+0% - +0%
+0.00ms - +0.01ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local69.38ms - 71.46ms-unsure 🔍
-1% - +3%
-1.04ms - +1.87ms
preact-main68.98ms - 71.03msunsure 🔍
-3% - +1%
-1.87ms - +1.04ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local6.17ms - 6.83ms-unsure 🔍
-2% - +12%
-0.11ms - +0.72ms
preact-main5.94ms - 6.44msunsure 🔍
-11% - +1%
-0.72ms - +0.11ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.32ms - 16.54ms-unsure 🔍
-2% - +1%
-0.41ms - +0.13ms
preact-main16.32ms - 16.81msunsure 🔍
-1% - +2%
-0.13ms - +0.41ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.77ms - 3.77ms-unsure 🔍
-0% - -0%
-0.01ms - -0.00ms
preact-main3.77ms - 3.78msunsure 🔍
+0% - +0%
+0.00ms - +0.01ms
-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #4867
  • Commit: 460d316

duration

VersionAvg timevs preact-localvs preact-main
preact-local62.58ms - 64.22ms-slower ❌
0% - 3%
0.09ms - 1.97ms
preact-main61.91ms - 62.82msfaster ✔
0% - 3%
0.09ms - 1.97ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.98ms - 2.98ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main2.99ms - 2.99msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local25.84ms - 26.61ms-unsure 🔍
-2% - +2%
-0.48ms - +0.53ms
preact-main25.87ms - 26.53msunsure 🔍
-2% - +2%
-0.53ms - +0.48ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local31.85ms - 33.27ms-unsure 🔍
-2% - +4%
-0.61ms - +1.33ms
preact-main31.54ms - 32.86msunsure 🔍
-4% - +2%
-1.33ms - +0.61ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local28.93ms - 29.94ms-unsure 🔍
-3% - +1%
-0.97ms - +0.44ms
preact-main29.21ms - 30.19msunsure 🔍
-1% - +3%
-0.44ms - +0.97ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local26.28ms - 27.28ms-unsure 🔍
-4% - +2%
-0.99ms - +0.49ms
preact-main26.49ms - 27.58msunsure 🔍
-2% - +4%
-0.49ms - +0.99ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local23.11ms - 24.14ms-unsure 🔍
-2% - +5%
-0.41ms - +1.08ms
preact-main22.75ms - 23.82msunsure 🔍
-5% - +2%
-1.08ms - +0.41ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local21.04ms - 21.91ms-unsure 🔍
-1% - +4%
-0.27ms - +0.87ms
preact-main20.81ms - 21.54msunsure 🔍
-4% - +1%
-0.87ms - +0.27ms
-
text-update

duration

VersionAvg timevs preact-localvs preact-main
preact-local2.01ms - 2.12ms-unsure 🔍
-5% - +3%
-0.10ms - +0.07ms
preact-main2.02ms - 2.14msunsure 🔍
-3% - +5%
-0.07ms - +0.10ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local0.96ms - 0.99ms-unsure 🔍
-4% - +2%
-0.04ms - +0.02ms
preact-main0.96ms - 1.01msunsure 🔍
-2% - +5%
-0.02ms - +0.04ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local32.38ms - 32.68ms-unsure 🔍
-0% - +1%
-0.10ms - +0.31ms
preact-main32.29ms - 32.56msunsure 🔍
-1% - +0%
-0.31ms - +0.10ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.24ms - 1.24ms-faster ✔
0% - 1%
0.00ms - 0.01ms
preact-main1.24ms - 1.24msslower ❌
0% - 1%
0.00ms - 0.01ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local29.73ms - 31.37ms-unsure 🔍
-4% - +4%
-1.16ms - +1.13ms
preact-main29.76ms - 31.37msunsure 🔍
-4% - +4%
-1.13ms - +1.16ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.93ms - 2.94ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-main2.94ms - 2.95msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms
-

tachometer-reporter-action v2 for CI

@github-actions
Copy link

github-actions bot commented Jul 6, 2025

Size Change: +259 B (+0.55%)

Total Size: 46.9 kB

Filename Size Change
compat/dist/compat.js 3.86 kB +82 B (+2.17%)
compat/dist/compat.mjs 3.77 kB +81 B (+2.19%)
compat/dist/compat.umd.js 3.92 kB +83 B (+2.17%)
dist/preact.js 4.6 kB -34 B (-0.73%)
dist/preact.mjs 4.61 kB -30 B (-0.65%)
dist/preact.umd.js 4.67 kB -36 B (-0.76%)
hooks/dist/hooks.js 1.55 kB +34 B (+2.24%)
hooks/dist/hooks.mjs 1.58 kB +40 B (+2.6%)
hooks/dist/hooks.umd.js 1.62 kB +39 B (+2.46%)
ℹ️ View Unchanged
Filename Size
debug/dist/debug.js 3.85 kB
debug/dist/debug.mjs 3.85 kB
debug/dist/debug.umd.js 3.94 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.mjs 271 B
devtools/dist/devtools.umd.js 346 B
jsx-runtime/dist/jsxRuntime.js 892 B
jsx-runtime/dist/jsxRuntime.mjs 861 B
jsx-runtime/dist/jsxRuntime.umd.js 966 B
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 473 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

@coveralls
Copy link

Coverage Status

coverage: 99.579% (+4.9%) from 94.727%
when pulling 460d316 on some-reverts
into d21722e on main.

@JoviDeCroock JoviDeCroock merged commit 2d6811d into main Jul 6, 2025
15 checks passed
@JoviDeCroock JoviDeCroock deleted the some-reverts branch July 6, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants