Skip to content

refactor(diff): set oldProps's default value on declaration#4959

Merged
JoviDeCroock merged 1 commit intopreactjs:mainfrom
ali-garajian:main
Nov 16, 2025
Merged

refactor(diff): set oldProps's default value on declaration#4959
JoviDeCroock merged 1 commit intopreactjs:mainfrom
ali-garajian:main

Conversation

@ali-garajian
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Nov 16, 2025

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +0% (-5.76ms - +2.44ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +2% (-0.07ms - +0.30ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +1% (-1.62ms - +0.87ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +4% (-0.06ms - +0.60ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -2% - +1% (-1.18ms - +0.47ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -5% - +4% (-0.09ms - +0.08ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -2% - +2% (-0.55ms - +0.65ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -3% - +2% (-0.96ms - +0.64ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +11% (-0.05ms - +0.69ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -5% - +4% (-0.05ms - +0.04ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local980.40ms - 985.74ms-unsure 🔍
-1% - +0%
-5.76ms - +2.44ms
preact-main981.61ms - 987.84msunsure 🔍
-0% - +1%
-2.44ms - +5.76ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.04ms - 19.04ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main19.04ms - 19.04msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.59ms - 16.94ms-unsure 🔍
-0% - +2%
-0.07ms - +0.30ms
preact-main16.59ms - 16.71msunsure 🔍
-2% - +0%
-0.30ms - +0.07ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.54ms - 1.54ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.54ms - 1.54msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local73.90ms - 75.70ms-unsure 🔍
-2% - +1%
-1.62ms - +0.87ms
preact-main74.31ms - 76.03msunsure 🔍
-1% - +2%
-0.87ms - +1.62ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local6.13ms - 6.71ms-unsure 🔍
-1% - +11%
-0.05ms - +0.69ms
preact-main5.86ms - 6.33msunsure 🔍
-11% - +1%
-0.69ms - +0.05ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.27ms - 16.82ms-unsure 🔍
-0% - +4%
-0.06ms - +0.60ms
preact-main16.09ms - 16.46msunsure 🔍
-4% - +0%
-0.60ms - +0.06ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.72ms - 3.73ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.72ms - 3.73msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #5217
  • Commit: 19f31ce

duration

VersionAvg timevs preact-localvs preact-main
preact-local61.47ms - 62.54ms-unsure 🔍
-2% - +1%
-1.18ms - +0.47ms
preact-main61.74ms - 62.99msunsure 🔍
-1% - +2%
-0.47ms - +1.18ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.99ms - 2.99ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main2.99ms - 2.99msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local25.91ms - 26.61ms-unsure 🔍
-1% - +3%
-0.17ms - +0.78ms
preact-main25.63ms - 26.27msunsure 🔍
-3% - +1%
-0.78ms - +0.17ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local32.86ms - 33.79ms-unsure 🔍
-2% - +2%
-0.79ms - +0.55ms
preact-main32.96ms - 33.92msunsure 🔍
-2% - +2%
-0.55ms - +0.79ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local33.05ms - 33.82ms-unsure 🔍
-2% - +2%
-0.56ms - +0.54ms
preact-main33.05ms - 33.84msunsure 🔍
-2% - +2%
-0.54ms - +0.56ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local25.62ms - 25.90ms-unsure 🔍
-1% - +1%
-0.29ms - +0.15ms
preact-main25.66ms - 26.00msunsure 🔍
-1% - +1%
-0.15ms - +0.29ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local25.83ms - 27.36ms-unsure 🔍
-2% - +6%
-0.57ms - +1.61ms
preact-main25.30ms - 26.85msunsure 🔍
-6% - +2%
-1.61ms - +0.57ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local21.06ms - 21.60ms-unsure 🔍
-2% - +1%
-0.44ms - +0.30ms
preact-main21.14ms - 21.66msunsure 🔍
-1% - +2%
-0.30ms - +0.44ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 120
  • Built by: CI #5217
  • Commit: 19f31ce

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.88ms - 2.00ms-unsure 🔍
-5% - +4%
-0.09ms - +0.08ms
preact-main1.88ms - 2.00msunsure 🔍
-4% - +5%
-0.08ms - +0.09ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.01ms - 1.08ms-unsure 🔍
-5% - +4%
-0.05ms - +0.04ms
preact-main1.01ms - 1.08msunsure 🔍
-4% - +5%
-0.04ms - +0.05ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local30.93ms - 32.06ms-unsure 🔍
-2% - +2%
-0.55ms - +0.65ms
preact-main31.24ms - 31.66msunsure 🔍
-2% - +2%
-0.65ms - +0.55ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.26ms - 1.26ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.26ms - 1.26msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local31.19ms - 32.41ms-unsure 🔍
-3% - +2%
-0.96ms - +0.64ms
preact-main31.45ms - 32.47msunsure 🔍
-2% - +3%
-0.64ms - +0.96ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.93ms - 2.94ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main2.93ms - 2.94msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-

tachometer-reporter-action v2 for CI

@JoviDeCroock JoviDeCroock merged commit 324b83f into preactjs:main Nov 16, 2025
12 checks passed
@coveralls
Copy link

Coverage Status

coverage: 99.442%. remained the same
when pulling 19f31ce on ali-garajian:main
into f10c898 on preactjs:main.

JoviDeCroock added a commit that referenced this pull request Nov 29, 2025
* refactor(children): remove redundant assignment to childVNode (#4951)

* refactor(children): remove redundant assignment to childVNode

* refactor(children): use key instead of childVNode.key

---------

Co-authored-by: Ali Garajian <ali.garajian@snapppay.ir>

* refactor(diff): no need to reset props and context when creating component (#4954)

* refactor(children): remove redundant assignment to childVNode

* refactor(children): use key instead of childVNode.key

* refactor(diff): no need to reset props and context when creating component

---------

Co-authored-by: Ali Garajian <ali.garajian@snapppay.ir>

* refactor(children): remove redundant assignment to oldVNode (#4956)

Co-authored-by: Ali Garajian <ali.garajian@snapppay.ir>

* refactor(diff): set oldProps default value on declaration (#4959)

---------

Co-authored-by: Ali Garajian <50337133+ali-garajian@users.noreply.github.com>
Co-authored-by: Ali Garajian <ali.garajian@snapppay.ir>
@JoviDeCroock JoviDeCroock mentioned this pull request Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants