refactor(diff): no need to reset props and context when creating component #4954
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Resultscreate10kduration
usedJSHeapSize
filter-listduration
usedJSHeapSize
hydrate1kduration
usedJSHeapSize
many-updatesduration
usedJSHeapSize
replace1kduration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-updateduration
usedJSHeapSize
tododuration
usedJSHeapSize
update10th1kduration
usedJSHeapSize
|
rschristian
approved these changes
Nov 7, 2025
Member
rschristian
left a comment
rschristian
left a comment
There was a problem hiding this comment.
Nice spot!
Size Change: -15 B (-0.03%)
Total Size: 47.5 kB
| Filename | Size | Change |
|---|---|---|
dist/preact.js |
4.71 kB | -5 B (-0.11%) |
dist/preact.mjs |
4.73 kB | -5 B (-0.11%) |
dist/preact.umd.js |
4.78 kB | -5 B (-0.1%) |
ℹ️ View Unchanged
| Filename | Size |
|---|---|
compat/dist/compat.js |
3.91 kB |
compat/dist/compat.mjs |
3.84 kB |
compat/dist/compat.umd.js |
3.96 kB |
debug/dist/debug.js |
3.9 kB |
debug/dist/debug.mjs |
3.9 kB |
debug/dist/debug.umd.js |
3.98 kB |
devtools/dist/devtools.js |
263 B |
devtools/dist/devtools.mjs |
273 B |
devtools/dist/devtools.umd.js |
348 B |
hooks/dist/hooks.js |
1.53 kB |
hooks/dist/hooks.mjs |
1.56 kB |
hooks/dist/hooks.umd.js |
1.6 kB |
jsx-runtime/dist/jsxRuntime.js |
892 B |
jsx-runtime/dist/jsxRuntime.mjs |
861 B |
jsx-runtime/dist/jsxRuntime.umd.js |
966 B |
test-utils/dist/testUtils.js |
473 B |
test-utils/dist/testUtils.mjs |
473 B |
test-utils/dist/testUtils.umd.js |
555 B |
JoviDeCroock
pushed a commit
that referenced
this pull request
Nov 29, 2025
…onent (#4954) * refactor(children): remove redundant assignment to childVNode * refactor(children): use key instead of childVNode.key * refactor(diff): no need to reset props and context when creating component --------- Co-authored-by: Ali Garajian <ali.garajian@snapppay.ir>
JoviDeCroock
added a commit
that referenced
this pull request
Nov 29, 2025
* refactor(children): remove redundant assignment to childVNode (#4951) * refactor(children): remove redundant assignment to childVNode * refactor(children): use key instead of childVNode.key --------- Co-authored-by: Ali Garajian <ali.garajian@snapppay.ir> * refactor(diff): no need to reset props and context when creating component (#4954) * refactor(children): remove redundant assignment to childVNode * refactor(children): use key instead of childVNode.key * refactor(diff): no need to reset props and context when creating component --------- Co-authored-by: Ali Garajian <ali.garajian@snapppay.ir> * refactor(children): remove redundant assignment to oldVNode (#4956) Co-authored-by: Ali Garajian <ali.garajian@snapppay.ir> * refactor(diff): set oldProps default value on declaration (#4959) --------- Co-authored-by: Ali Garajian <50337133+ali-garajian@users.noreply.github.com> Co-authored-by: Ali Garajian <ali.garajian@snapppay.ir>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
propsandcontextare already being set inBaseComponentwhen creating either a class component or an FC