refactor(children): remove redundant assignment to childVNode by ali-garajian · Pull Request #4951 · preactjs/preact

ali-garajian · 2025-10-31T16:10:29Z

No description provided.

github-actions · 2025-10-31T16:10:56Z

📊 Tachometer Benchmark Results

Summary

duration

create10k: unsure 🔍 -1% - +0% (-5.62ms - +3.69ms)
^{preact-local vs preact-main}
filter-list: unsure 🔍 -0% - +0% (-0.04ms - +0.03ms)
^{preact-local vs preact-main}
hydrate1k: unsure 🔍 -1% - +3% (-0.66ms - +2.30ms)
^{preact-local vs preact-main}
many-updates: unsure 🔍 -1% - +4% (-0.22ms - +0.65ms)
^{preact-local vs preact-main}
replace1k: unsure 🔍 -0% - +2% (-0.10ms - +1.47ms)
^{preact-local vs preact-main}
text-update: unsure 🔍 -5% - +4% (-0.10ms - +0.08ms)
^{preact-local vs preact-main}
todo: unsure 🔍 -1% - +1% (-0.23ms - +0.22ms)
^{preact-local vs preact-main}
update10th1k: unsure 🔍 -4% - +4% (-1.07ms - +1.18ms)
^{preact-local vs preact-main}

usedJSHeapSize

create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
^{preact-local vs preact-main}
filter-list: unsure 🔍 -1% - +1% (-0.01ms - +0.01ms)
^{preact-local vs preact-main}
hydrate1k: unsure 🔍 -5% - +8% (-0.32ms - +0.50ms)
^{preact-local vs preact-main}
many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
^{preact-local vs preact-main}
replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
^{preact-local vs preact-main}
text-update: unsure 🔍 -3% - +3% (-0.03ms - +0.03ms)
^{preact-local vs preact-main}
todo: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
^{preact-local vs preact-main}
update10th1k: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
^{preact-local vs preact-main}

Results

create10k

Browser: chrome-headless
Sample size: 50
Built by: CI #5202
Commit: b26b4de

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	979.85ms - 985.67ms	-	unsure 🔍 -1% - +0% -5.62ms - +3.69ms
preact-main	980.10ms - 987.36ms	unsure 🔍 -0% - +1% -3.69ms - +5.62ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	19.04ms - 19.04ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-main	19.04ms - 19.04ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

filter-list

Browser: chrome-headless
Sample size: 50
Built by: CI #5202
Commit: b26b4de

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.54ms - 16.58ms	-	unsure 🔍 -0% - +0% -0.04ms - +0.03ms
preact-main	16.54ms - 16.59ms	unsure 🔍 -0% - +0% -0.03ms - +0.04ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.54ms - 1.55ms	-	unsure 🔍 -1% - +1% -0.01ms - +0.01ms
preact-main	1.54ms - 1.55ms	unsure 🔍 -1% - +1% -0.01ms - +0.01ms	-

hydrate1k

Browser: chrome-headless
Sample size: 90
Built by: CI #5202
Commit: b26b4de

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	70.95ms - 73.02ms	-	unsure 🔍 -1% - +3% -0.66ms - +2.30ms
preact-main	70.11ms - 72.22ms	unsure 🔍 -3% - +1% -2.30ms - +0.66ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	6.16ms - 6.75ms	-	unsure 🔍 -5% - +8% -0.32ms - +0.50ms
preact-main	6.09ms - 6.65ms	unsure 🔍 -8% - +5% -0.50ms - +0.32ms	-

many-updates

Browser: chrome-headless
Sample size: 50
Built by: CI #5202
Commit: b26b4de

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	15.99ms - 16.79ms	-	unsure 🔍 -1% - +4% -0.22ms - +0.65ms
preact-main	16.01ms - 16.35ms	unsure 🔍 -4% - +1% -0.65ms - +0.22ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.73ms - 3.73ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.01ms
preact-main	3.72ms - 3.73ms	unsure 🔍 -0% - +0% -0.01ms - +0.00ms	-

replace1k

Browser: chrome-headless
Sample size: 100
Built by: CI #5202
Commit: b26b4de

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	59.02ms - 60.30ms	-	unsure 🔍 -0% - +2% -0.10ms - +1.47ms
preact-main	58.53ms - 59.43ms	unsure 🔍 -2% - +0% -1.47ms - +0.10ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.99ms - 2.99ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-main	2.99ms - 2.99ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

run-warmup-0

Version	Avg time	vs preact-local	vs preact-main
preact-local	24.53ms - 25.20ms	-	unsure 🔍 -3% - +1% -0.65ms - +0.34ms
preact-main	24.66ms - 25.39ms	unsure 🔍 -1% - +3% -0.34ms - +0.65ms	-

run-warmup-1

Version	Avg time	vs preact-local	vs preact-main
preact-local	30.57ms - 31.52ms	-	unsure 🔍 -4% - +0% -1.40ms - +0.01ms
preact-main	31.21ms - 32.27ms	unsure 🔍 -0% - +5% -0.01ms - +1.40ms	-

run-warmup-2

Version	Avg time	vs preact-local	vs preact-main
preact-local	30.27ms - 30.96ms	-	unsure 🔍 -1% - +2% -0.36ms - +0.58ms
preact-main	30.19ms - 30.83ms	unsure 🔍 -2% - +1% -0.58ms - +0.36ms	-

run-warmup-3

Version	Avg time	vs preact-local	vs preact-main
preact-local	23.58ms - 23.85ms	-	unsure 🔍 -1% - +1% -0.27ms - +0.13ms
preact-main	23.64ms - 23.93ms	unsure 🔍 -1% - +1% -0.13ms - +0.27ms	-

run-warmup-4

Version	Avg time	vs preact-local	vs preact-main
preact-local	25.15ms - 26.63ms	-	unsure 🔍 -3% - +5% -0.82ms - +1.30ms
preact-main	24.89ms - 26.41ms	unsure 🔍 -5% - +3% -1.30ms - +0.82ms	-

run-final

Version	Avg time	vs preact-local	vs preact-main
preact-local	19.89ms - 20.65ms	-	unsure 🔍 -0% - +5% +0.00ms - +0.91ms
preact-main	19.58ms - 20.05ms	faster ✔ 0% - 4% 0.00ms - 0.91ms	-

text-update

Browser: chrome-headless
Sample size: 120
Built by: CI #5202
Commit: b26b4de

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.07ms - 2.19ms	-	unsure 🔍 -5% - +4% -0.10ms - +0.08ms
preact-main	2.07ms - 2.20ms	unsure 🔍 -4% - +5% -0.08ms - +0.10ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	0.98ms - 1.03ms	-	unsure 🔍 -3% - +3% -0.03ms - +0.03ms
preact-main	0.98ms - 1.02ms	unsure 🔍 -3% - +3% -0.03ms - +0.03ms	-

todo

Browser: chrome-headless
Sample size: 50
Built by: CI #5202
Commit: b26b4de

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	31.05ms - 31.32ms	-	unsure 🔍 -1% - +1% -0.23ms - +0.22ms
preact-main	31.01ms - 31.37ms	unsure 🔍 -1% - +1% -0.22ms - +0.23ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.26ms - 1.26ms	-	unsure 🔍 +0% - +0% +0.00ms - +0.00ms
preact-main	1.26ms - 1.26ms	unsure 🔍 -0% - -0% -0.00ms - -0.00ms	-

update10th1k

Browser: chrome-headless
Sample size: 60
Built by: CI #5202
Commit: b26b4de

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	27.73ms - 29.35ms	-	unsure 🔍 -4% - +4% -1.07ms - +1.18ms
preact-main	27.70ms - 29.27ms	unsure 🔍 -4% - +4% -1.18ms - +1.07ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.94ms - 2.95ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.01ms
preact-main	2.94ms - 2.95ms	unsure 🔍 -0% - +0% -0.01ms - +0.00ms	-

_{tachometer-reporter-action v2 for CI}

coveralls · 2025-10-31T16:14:23Z

coverage: 99.442%. remained the same
when pulling b26b4de on ali-garajian:main
into 5bea6be on preactjs:main.

JoviDeCroock

Great find! Looks like it saves 2 bytes, thank you for cleaning this up and contributing! If you want you can also backport this to v10.x which I intend to draft a release for this weekend

rschristian

Byte diff comes from the second commit, somehow the first has no effect? Wonder if terser is stripping that for us or if compression is really just a marvel

Good catch tho!

* refactor(children): remove redundant assignment to childVNode * refactor(children): use key instead of childVNode.key --------- Co-authored-by: Ali Garajian <ali.garajian@snapppay.ir>

* refactor(children): remove redundant assignment to childVNode (#4951) * refactor(children): remove redundant assignment to childVNode * refactor(children): use key instead of childVNode.key --------- Co-authored-by: Ali Garajian <ali.garajian@snapppay.ir> * refactor(diff): no need to reset props and context when creating component (#4954) * refactor(children): remove redundant assignment to childVNode * refactor(children): use key instead of childVNode.key * refactor(diff): no need to reset props and context when creating component --------- Co-authored-by: Ali Garajian <ali.garajian@snapppay.ir> * refactor(children): remove redundant assignment to oldVNode (#4956) Co-authored-by: Ali Garajian <ali.garajian@snapppay.ir> * refactor(diff): set oldProps default value on declaration (#4959) --------- Co-authored-by: Ali Garajian <50337133+ali-garajian@users.noreply.github.com> Co-authored-by: Ali Garajian <ali.garajian@snapppay.ir>

refactor(children): remove redundant assignment to childVNode

6cbe22c

refactor(children): use key instead of childVNode.key

b26b4de

JoviDeCroock approved these changes Oct 31, 2025

View reviewed changes

JoviDeCroock merged commit 84c10e4 into preactjs:main Oct 31, 2025
13 checks passed

rschristian approved these changes Oct 31, 2025

View reviewed changes

shacha086 mentioned this pull request Dec 16, 2025

Render problem since Preact 10.28.0 #4973

Closed

1 task

Uh oh!

Conversation

ali-garajian commented Oct 31, 2025

Uh oh!

github-actions bot commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

duration

usedJSHeapSize

Results

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

run-warmup-0

run-warmup-1

run-warmup-2

run-warmup-3

run-warmup-4

run-final

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

Uh oh!

coveralls commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JoviDeCroock left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rschristian left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Oct 31, 2025 •

edited

Loading

coveralls commented Oct 31, 2025 •

edited

Loading

JoviDeCroock left a comment •

edited

Loading