Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seqr non-preemptible pools #243

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add seqr non-preemptible pools #243

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
645ec6c
Non-preemptible seqr pool
vladsavelyev Nov 11, 2022
a931e91
Update batch/sql/add-seqr-nonpreemptible-pools.sql
vladsavelyev Nov 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions batch/sql/add-seqr-nonpreemptible-pools.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
-- Adds dedicated pools for the seqr loading pipeline, with the 'seqr' pool label, but non-preemptible versions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could potentially add these changes simply to add-seqr-pools.sql, as we haven't integrated that with CI anyhow.

I.e. regarding your question of reproducibility: ideally we'd add all our "CPG"-custom pools in here (including the large-cohorts one, so we should probably rename this to add-cpg-pools.sql or similar) and add another build step in build.yaml, so these pools also get created for dev deployments, for example. I was hoping to do that once the upstream merge had been done, but that ended up taking way longer (in fact has just been recently merged!).

-- run after add-seqr-pools.sql and add-nonpreemptible-pools.sql

INSERT INTO inst_colls (`name`, `is_pool`, `boot_disk_size_gb`, `max_instances`, `max_live_instances`, `cloud`)
SELECT 'seqr-standard-np', 1, boot_disk_size_gb, max_instances, max_live_instances, cloud
FROM inst_colls
WHERE name = 'standard';

INSERT INTO inst_colls (`name`, `is_pool`, `boot_disk_size_gb`, `max_instances`, `max_live_instances`, `cloud`)
SELECT 'seqr-highmem-np', 1, boot_disk_size_gb, max_instances, max_live_instances, cloud
FROM inst_colls
WHERE name = 'highmem';

INSERT INTO inst_colls (`name`, `is_pool`, `boot_disk_size_gb`, `max_instances`, `max_live_instances`, `cloud`)
SELECT 'seqr-highcpu-np', 1, boot_disk_size_gb, max_instances, max_live_instances, cloud
FROM inst_colls
WHERE name = 'highcpu';

INSERT INTO pools (`name`, `worker_type`, `worker_cores`, `worker_local_ssd_data_disk`,
`worker_external_ssd_data_disk_size_gb`, `enable_standing_worker`, `standing_worker_cores`,
`preemptible`, `label`)
SELECT 'seqr-standard-np', worker_type, worker_cores, worker_local_ssd_data_disk,
worker_external_ssd_data_disk_size_gb, FALSE, standing_worker_cores,
FALSE, 'seqr'
FROM pools
WHERE name = 'standard';

INSERT INTO pools (`name`, `worker_type`, `worker_cores`, `worker_local_ssd_data_disk`,
`worker_external_ssd_data_disk_size_gb`, `enable_standing_worker`, `standing_worker_cores`,
`preemptible`, `label`)
SELECT 'seqr-highmem-np', worker_type, worker_cores, worker_local_ssd_data_disk,
worker_external_ssd_data_disk_size_gb, FALSE, standing_worker_cores,
FALSE, 'seqr'
FROM pools
WHERE name = 'highmem';

INSERT INTO pools (`name`, `worker_type`, `worker_cores`, `worker_local_ssd_data_disk`,
`worker_external_ssd_data_disk_size_gb`, `enable_standing_worker`, `standing_worker_cores`,
`preemptible`, `label`)
SELECT 'seqr-highcpu-np', worker_type, worker_cores, worker_local_ssd_data_disk,
worker_external_ssd_data_disk_size_gb, FALSE, standing_worker_cores,
FALSE, 'seqr'
FROM pools
WHERE name = 'highcpu';