Add seqr non-preemptible pools
#243
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgruen
suggested changes
Nov 13, 2022
| @@ -0,0 +1,44 @@ | |||
| -- Adds dedicated pools for the seqr loading pipeline, with the 'seqr' pool label, but non-preemptible versions | |||
There was a problem hiding this comment.
You could potentially add these changes simply to add-seqr-pools.sql, as we haven't integrated that with CI anyhow.
I.e. regarding your question of reproducibility: ideally we'd add all our "CPG"-custom pools in here (including the large-cohorts one, so we should probably rename this to add-cpg-pools.sql or similar) and add another build step in build.yaml, so these pools also get created for dev deployments, for example. I was hoping to do that once the upstream merge had been done, but that ended up taking way longer (in fact has just been recently merged!).
Co-authored-by: Leonhard Gruenschloss <[email protected]>
lgruen
suggested changes
Jan 19, 2023
There was a problem hiding this comment.
@violetbrina Would you like to take a stab at the integration outlined in #243 (comment)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if that would work, but just a guess.
Seems like it's a bit verbose to add a pool, but I guess we aren't going to add many new pools. Hail upstream seem to be satisfied with this solution as well
By the way, how the
large-cohortpools were added? Do you have sql commands for that locally? Did you mean to addadd-seqr-pools.sqljust as an example, and we shouldn't add more sql files intobatch/sql? We probably still should store sqls somewhere for repdocubility