Bump to stable2409-6 #623

bkontur · 2025-03-13T23:59:33Z

This PR contains:

bump to stable2409-6

TODO:

fix penpal-runtime compilation https://github.com/polkadot-fellows/runtimes/actions/runs/13853959747/job/38766523729?pr=623
check electra setup
confirm that this PR is compatible and doing the same as Release 1.4.1 #608 (@Ank4n)

…e2409-4)

bkontur · 2025-03-14T08:46:40Z

/cmd fmt

bkontur · 2025-03-14T08:46:51Z

/cmd fmt

github-actions · 2025-03-14T09:12:08Z

Command "fmt" has started 🚀 See logs here

github-actions · 2025-03-14T09:14:03Z

Command "fmt" has finished ✅ See logs here

github-actions · 2025-03-14T09:19:55Z

Command "fmt" has started 🚀 See logs here

github-actions · 2025-03-14T09:21:52Z

Command "fmt" has finished ✅ See logs here

system-parachains/bridge-hubs/bridge-hub-polkadot/src/bridge_to_ethereum_config.rs

claravanstaden

Set Electra epochs in the future, until real epoch is announced.

system-parachains/bridge-hubs/bridge-hub-polkadot/src/bridge_to_ethereum_config.rs

Co-authored-by: Clara van Staden <[email protected]>

…ectly here from https://github.com/paritytech/polkadot-sdk/blob/stable2409/bridges/chains

bkontur · 2025-03-14T13:05:48Z

/cmd fmt

github-actions · 2025-03-14T13:47:11Z

Command "fmt" has started 🚀 See logs here

github-actions · 2025-03-14T13:49:20Z

Command "fmt" has finished ✅ See logs here

This reverts commit d6e4b7a.

…oved directly here from https://github.com/paritytech/polkadot-sdk/blob/stable2409/bridges/chains" This reverts commit cb78e0f.

This reverts commit 554ec5b.

…table2409

claravanstaden

Adding Electra activation epoch: https://github.com/ethereum/EIPs/pull/9560/files

system-parachains/bridge-hubs/bridge-hub-polkadot/src/bridge_to_ethereum_config.rs

…o_ethereum_config.rs Co-authored-by: Clara van Staden <[email protected]>

bkontur · 2025-03-28T22:05:41Z

* [ ]  confirm that this PR is compatible and doing the same as [Release 1.4.1 #608](https://github.com/polkadot-fellows/runtimes/pull/608) (@Ank4n)

@Ank4n I know that I asked you this before in Element, but could please confirm this?

Ank4n · 2025-03-31T10:52:36Z

* [ ]  confirm that this PR is compatible and doing the same as [Release 1.4.1 #608](https://github.com/polkadot-fellows/runtimes/pull/608) (@Ank4n)
@Ank4n I know that I asked you this before in Element, but could please confirm this?

Yes, verified on version 5.0.1 of pallet-delegated-staking, the staking accounts are hardcoded to be excluded from nomination pools.

Ank4n · 2025-03-31T10:56:23Z

relay/kusama/src/lib.rs

+	fn filter(who: &AccountId) -> bool {
+		pallet_nomination_pools::AllPoolMembers::<Runtime>::contains(who)
+	}


Ank4n · 2025-03-31T10:57:00Z

relay/polkadot/src/lib.rs

+	fn filter(who: &AccountId) -> bool {
+		pallet_nomination_pools::AllPoolMembers::<Runtime>::contains(who)
+	}


Would be nice to write a small test for this ;)

Would be nice to write a small test for this ;)

I am checking paritytech/polkadot-sdk@stable2409...bkchr-fix-the-thing and there were several pallet unit tests added:
existing_pool_member_cannot_stake
stakers_cannot_join_pool
restricted_accounts_cannot_join
restricted_accounts_can_only_withdraw
permissionless_withdraw_overstake

What should this small test cover/do? Some pseudo-code is ok:

// prepare account // create pool // accounts join the pool // <do-something-else> // check something1 // check something2

@Ank4n Could you please take care of this? Or at least, write down what needs to be tested, and I can write a test at runtimes.

@bkchr tests are added (de119a3) by @Ank4n

bkchr

We should add a small test for the staking changes. Should not be that hard.

bkchr · 2025-03-31T20:47:18Z

relay/polkadot/src/lib.rs

+	fn filter(who: &AccountId) -> bool {
+		pallet_nomination_pools::AllPoolMembers::<Runtime>::contains(who)
+	}


Would be nice to write a small test for this ;)

bkchr · 2025-03-31T20:47:53Z

CHANGELOG.md

+
+### Changed
+
+- Apply patch for stable2409-6


Please use the default syntax for these changes.

CHANGELOG.md

* add tests to ensure dual stake prevention measures are correctly configured * stake right amount

system-parachains/bridge-hubs/bridge-hub-polkadot/src/bridge_to_ethereum_config.rs

…o_ethereum_config.rs Co-authored-by: Clara van Staden <[email protected]>

…table2409

claravanstaden

Looks good!

bkontur · 2025-04-07T13:33:57Z

/merge

fellowship-merge-bot · 2025-04-07T13:35:55Z

Enabled auto-merge in Pull Request

Available commands

/merge: Enables auto-merge for Pull Request
/merge cancel: Cancels auto-merge for Pull Request
/merge help: Shows this menu

For more information see the documentation

@Ank4n

* Bump to stable2409-6 (polkadot-fellows#623) This PR contains: - bump to stable2409-6 ## TODO: - [x] fix penpal-runtime compilation https://github.com/polkadot-fellows/runtimes/actions/runs/13853959747/job/38766523729?pr=623 - [x] check electra setup - [x] confirm that this PR is compatible and doing the same as polkadot-fellows#608 (@Ank4n) --------- Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Clara van Staden <[email protected]> Co-authored-by: Ankan <[email protected]> * Format --------- Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Clara van Staden <[email protected]> Co-authored-by: Ankan <[email protected]>

bkontur added 6 commits March 13, 2025 23:45

Revert back to polkadot-stable2409-4 (psvm --version polkadot-stabl…

4b54cd7

…e2409-4)

psvm --version polkadot-stable2409-6

879ae89

Patch dry-run

c92c13b

Patch filter

1cb6d83

Patched bridge tests

4028387

Patched snowbridge (TODO)

17789e8

bkontur closed this Mar 14, 2025

bkontur reopened this Mar 14, 2025

Update from bkontur running command 'fmt'

87e03aa

changelog

e8c0ab8

bkontur commented Mar 14, 2025

View reviewed changes

system-parachains/bridge-hubs/bridge-hub-polkadot/src/bridge_to_ethereum_config.rs Show resolved Hide resolved

system-parachains/bridge-hubs/bridge-hub-polkadot/src/bridge_to_ethereum_config.rs Outdated Show resolved Hide resolved

We don't need bp-polkadot-bulletin

554ec5b

claravanstaden reviewed Mar 14, 2025

View reviewed changes

system-parachains/bridge-hubs/bridge-hub-polkadot/src/bridge_to_ethereum_config.rs Outdated Show resolved Hide resolved

system-parachains/bridge-hubs/bridge-hub-polkadot/src/bridge_to_ethereum_config.rs Outdated Show resolved Hide resolved

bkontur and others added 4 commits March 14, 2025 12:05

Apply suggestions from code review

b0949a4

Co-authored-by: Clara van Staden <[email protected]>

Bump penpal-runtime

63237e0

Removed deps (bp-polkadot, bp-kusama) from polkadot-sdk and moved dir…

cb78e0f

…ectly here from https://github.com/paritytech/polkadot-sdk/blob/stable2409/bridges/chains

Fix dry-run emulated tests

bb2bc01

bkontur mentioned this pull request Mar 14, 2025

Post polkadot-sdk migration leftovers paritytech/parity-bridges-common#2950

Closed

4 tasks

bkontur added this to @bkontur's board Mar 14, 2025

bkontur moved this to In Progress in @bkontur's board Mar 14, 2025

Update from bkontur running command 'fmt'

d6e4b7a

bkontur added 3 commits March 18, 2025 09:58

Revert "Update from bkontur running command 'fmt'"

115983e

This reverts commit d6e4b7a.

Revert "Removed deps (bp-polkadot, bp-kusama) from polkadot-sdk and m…

b421940

…oved directly here from https://github.com/paritytech/polkadot-sdk/blob/stable2409/bridges/chains" This reverts commit cb78e0f.

Revert "We don't need bp-polkadot-bulletin"

cbec648

This reverts commit 554ec5b.

raymondkfcheung approved these changes Mar 28, 2025

View reviewed changes

Merge remote-tracking branch 'polkadot-fellows/main' into bko-patch-s…

c85fd01

…table2409

claravanstaden reviewed Mar 28, 2025

View reviewed changes

system-parachains/bridge-hubs/bridge-hub-polkadot/src/bridge_to_ethereum_config.rs Outdated Show resolved Hide resolved

Update system-parachains/bridge-hubs/bridge-hub-polkadot/src/bridge_t…

876de23

…o_ethereum_config.rs Co-authored-by: Clara van Staden <[email protected]>

acatangiu approved these changes Mar 28, 2025

View reviewed changes

bkontur mentioned this pull request Mar 28, 2025

Release 1.4.3 #654

Closed

3 tasks

Ank4n reviewed Mar 31, 2025

View reviewed changes

bkchr reviewed Mar 31, 2025

View reviewed changes

bkontur commented Apr 1, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

bkontur and others added 2 commits April 1, 2025 09:34

Update CHANGELOG.md

a4ed574

Dual stake tests (#11)

de119a3

* add tests to ensure dual stake prevention measures are correctly configured * stake right amount

claravanstaden reviewed Apr 3, 2025

View reviewed changes

system-parachains/bridge-hubs/bridge-hub-polkadot/src/bridge_to_ethereum_config.rs Outdated Show resolved Hide resolved

Update system-parachains/bridge-hubs/bridge-hub-polkadot/src/bridge_t…

d0d0602

…o_ethereum_config.rs Co-authored-by: Clara van Staden <[email protected]>

acatangiu approved these changes Apr 4, 2025

View reviewed changes

Merge remote-tracking branch 'polkadot-fellows/main' into bko-patch-s…

f6283c3

…table2409

claravanstaden approved these changes Apr 4, 2025

View reviewed changes

sandreim approved these changes Apr 7, 2025

View reviewed changes

fellowship-merge-bot bot merged commit c10aa17 into polkadot-fellows:main Apr 7, 2025
64 checks passed

bkontur deleted the bko-patch-stable2409 branch April 7, 2025 13:38

bkontur moved this from In Progress to Done in @bkontur's board Apr 9, 2025

bkontur mentioned this pull request Apr 10, 2025

Snowbridge - Fix penpal runtime and more tests transfer PNA paritytech/polkadot-sdk#8038

Merged

Bump to stable2409-6 #623

Bump to stable2409-6 #623

Uh oh!

Conversation

bkontur commented Mar 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO:

Uh oh!

bkontur commented Mar 14, 2025

Uh oh!

bkontur commented Mar 14, 2025

Uh oh!

github-actions bot commented Mar 14, 2025

Uh oh!

github-actions bot commented Mar 14, 2025

Uh oh!

github-actions bot commented Mar 14, 2025

Uh oh!

github-actions bot commented Mar 14, 2025

Uh oh!

Uh oh!

Uh oh!

claravanstaden left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bkontur commented Mar 14, 2025

Uh oh!

github-actions bot commented Mar 14, 2025

Uh oh!

github-actions bot commented Mar 14, 2025

Uh oh!

claravanstaden left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bkontur commented Mar 28, 2025

Uh oh!

Ank4n commented Mar 31, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bkchr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

claravanstaden left a comment

Choose a reason for hiding this comment

Uh oh!

bkontur commented Apr 7, 2025

Uh oh!

Uh oh!

fellowship-merge-bot bot commented Apr 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

bkontur commented Mar 13, 2025 •

edited

Loading