eth_getLogs return expected error/message for unknown hash#1079
Merged
sorpaas merged 2 commits intopolkadot-evm:masterfrom Jun 22, 2023
Merged
eth_getLogs return expected error/message for unknown hash#1079sorpaas merged 2 commits intopolkadot-evm:masterfrom
eth_getLogs return expected error/message for unknown hash#1079sorpaas merged 2 commits intopolkadot-evm:masterfrom
Conversation
|
Solves #1069 |
boundless-forest
approved these changes
Jun 21, 2023
sorpaas
approved these changes
Jun 22, 2023
koushiro
pushed a commit
to alt-research/frontier
that referenced
this pull request
Jul 12, 2023
…t-evm#1079) * `eth_getLogs` return expected error/message for unknown hash * prettier
Closed
37 tasks
Closed
46 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported by a project deployed on moonbeam, calls to
eth_getLogswith a non-existingblockHashshould return an rpc error messageunknown block(e.g. Infura webservices). This PR fixes it.