Change eth_getLogs reply to be consistent with Ethereum when querying for non-existent block hashes

[tgmichel]

What does it do?

On Moonbeam clients, eth_getLogs returns empty results when asking for a random, non-existent, blockhash. On Ethereum, it returns an error with the message unknown block

What important points should reviewers know?

To replicate run the following curl commands:

MOONBASE ALPHA:
Request:

curl --location 'https://rpc.api.moonbase.moonbeam.network' \
--header 'Content-Type: application/json' \
--data '{
    "jsonrpc":"2.0",
    "id":1,
    "method":"eth_getLogs",
    "params": [{"blockHash":"0x5f273a37594f87b34d1e329d644f977fe56afaa6078d144e98d6106baf076875"}]
  }'

Response:

{
    "jsonrpc": "2.0",
    "result": [],
    "id": 1
}

INFURA SEPOLIA

Request:

curl --location 'https://sepolia.infura.io/v3/bf0136b4b47b423f89d0547938f9d65d' \
--header 'Content-Type: application/json' \
--data '{
    "jsonrpc":"2.0",
    "id":1,
    "method":"eth_getLogs",
    "params": [{"blockHash":"0x5f273a37594f87b34d1e329d644f977fe56afaa6078d144e98d6106baf076875"}]
  }'

Response:

{
    "jsonrpc": "2.0",
    "id": 1,
    "error": {
        "code": -32000,
        "message": "unknown block"
    }
}

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

• eth_getLogs return expected error/message for unknown hash polkadot-evm/frontier#1079

⚠️ Breaking Changes ⚠️

❗ Changes the jsonrpc response when querying for not existing block hashes from

{
    "jsonrpc": "2.0",
    "id": 1,
    "result": []
}

to

{
    "jsonrpc": "2.0",
    "id": 1,
    "error": {
        "code": -32000,
        "message": "unknown block"
    }
}

[github-actions]

Coverage generated "Wed Jun 14 14:41:51 UTC 2023":
https://s3.amazonaws.com/moonbeam-coverage/pulls/2350/html/index.html

Master coverage: 71.22%
Pull coverage: 71.22%