Skip to content

eth_getLogs return expected error/message for unknown hash #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sorpaas merged 2 commits into from
Jun 22, 2023
Merged

eth_getLogs return expected error/message for unknown hash #1079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bccb73d
`eth_getLogs` return expected error/message for unknown hash
tgmichel Jun 14, 2023
c4c5369
prettier
tgmichel Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/rpc/src/eth/filter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ where
.map_err(|err| internal_err(format!("{:?}", err)))?
{
Some(hash) => hash,
_ => return Ok(Vec::new()),
_ => return Err(crate::err(-32000, "unknown block", None)),
};
let schema = fc_storage::onchain_storage_schema(client.as_ref(), substrate_hash);

Expand Down
10 changes: 10 additions & 0 deletions ts-tests/tests/test-log-filtering.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,4 +83,14 @@ describeWithFrontier("Frontier RPC (Log filtering)", (context) => {
expect(request.result.length).to.be.eq(0);
}
});

step("EthApi::getLogs - should return `unknown block`.", async function () {
let request = await customRequest(context.web3, "eth_getLogs", [
{
blockHash: "0x1234000000000000000000000000000000000000000000000000000000000000",
},
]);
expect(request.error.message).to.be.equal("unknown block");
expect(request.error.code).to.be.equal(-32000);
});
});