Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(python)!: drop Python 3.7 support #9679

Merged
merged 7 commits into from
Jul 3, 2023
Merged

build(python)!: drop Python 3.7 support #9679

merged 7 commits into from
Jul 3, 2023

Conversation

stinodego
Copy link
Contributor

Re-opened from #7949

Changes:

  • Set required Python version to >=3.8
  • Set PyO3 abi3 feature to Python 3.8
  • Update CI to run on Python 3.8 instead of 3.7 (for release, test, and mypy jobs).
  • Update some typing imports
  • Remove some typing workarounds
  • Update pandas-stubs version and update some pandas type hints

Notes:

  • We still must allow untyped calls for mypy on Python 3.8 due to the backports.zoneinfo package having some issues.

@github-actions github-actions bot added breaking Change that breaks backwards compatibility build Changes that affect the build system or external dependencies python Related to Python Polars labels Jul 2, 2023
@stinodego stinodego added this to the Python Polars 1.0.0 milestone Jul 2, 2023
@stinodego stinodego changed the title build(python)!: Drop Python 3.7 support build(python)!: drop Python 3.7 support Jul 2, 2023
@ritchie46
Copy link
Member

I think we can just merge this right? Doesn't need a major/breaking version? Numpy dropped support on version 1.22.

@ritchie46
Copy link
Member

Shall we wait another release? 3.7 downloads proportion is still on 40%. :/

@stinodego
Copy link
Contributor Author

Shall we wait another release? 3.7 downloads proportion is still on 40%. :/

I really wonder where those downloads are coming from 🤔

I'd say let this sit and merge it whenever we're going for the next breaking release. Deal?

@ritchie46
Copy link
Member

Yeap, sounds good. Hopefully these downloads are pinned to an older version and would never be updated.

@stinodego
Copy link
Contributor Author

Yeap, sounds good. Hopefully these downloads are pinned to an older version and would never be updated.

pandas is also still on 40% Python 3.7 downloads, and they have dropped it 6 months ago.

In the end, Polars 0.18.x is still available on Python 3.7. If you want the latest features and fixes, you have to run a supported Python version. I don't see any issue with that.

@mcrumiller
Copy link
Contributor

mcrumiller commented Jul 2, 2023

I really wonder where those downloads are coming from 🤔

They're most likely companies like mine that offer employees software via an in-house software repository that is always way way out of date for "support" reasons. Using no-longer-supported software is the status quo.

@ritchie46
Copy link
Member

Ok, let's merge it then!

@ritchie46 ritchie46 merged commit f1470c2 into main Jul 3, 2023
@ritchie46 ritchie46 deleted the drop-python-37 branch July 3, 2023 09:54
@stinodego stinodego removed the breaking Change that breaks backwards compatibility label Jul 3, 2023
c-peters pushed a commit to c-peters/polars that referenced this pull request Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencies python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants