Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(python)!: Drop Python 3.7 support #7949

Closed
wants to merge 6 commits into from

Conversation

stinodego
Copy link
Contributor

@stinodego stinodego commented Apr 3, 2023

!! THIS IS A BREAKING CHANGE !!

Re-opened from #6824

Changes:

  • Set required Python version to >=3.8
  • Set PyO3 abi3 feature to Python 3.8
  • Update CI to run on Python 3.8 instead of 3.7 (for release, test, and mypy jobs).
  • Update some typing imports
  • Remove some typing workarounds
  • Update pandas-stubs version and update some pandas type hints

Notes:

  • We still must allow untyped calls for mypy on Python 3.8 due to the backports.zoneinfo package having some issues.

I'd like to have this part of the 0.17.0 release, but if you prefer we can keep supporting Python 3.7 until end of life (27 June 2023). In that case we'd probably merge this with the 1.0.0 release of Polars.

@stinodego stinodego added this to the Python Polars 0.17.0 milestone Apr 3, 2023
@github-actions github-actions bot added breaking Change that breaks backwards compatibility build Changes that affect the build system or external dependencies python Related to Python Polars labels Apr 3, 2023
@ritchie46
Copy link
Member

I really want to be a bit conservative here. Python 3.7 is our biggest share in downloads still. https://pypistats.org/packages/polars

@stinodego
Copy link
Contributor Author

Interesting! Definitely, we should wait with this for now then. Let's re-assess in the 1.0.0 release 👍

@stinodego stinodego added the do not merge This pull requests should not be merged right now label Apr 3, 2023
ankit-gautam23

This comment was marked as spam.

@stinodego
Copy link
Contributor Author

Rebasing this on a new branch.

@stinodego stinodego closed this Jul 2, 2023
@stinodego stinodego removed this from the Python Polars 1.0.0 milestone Jul 2, 2023
@stinodego stinodego deleted the drop-python-37-v2 branch December 8, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Change that breaks backwards compatibility build Changes that affect the build system or external dependencies do not merge This pull requests should not be merged right now python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants