Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect stub file causes type checking error #125

Open
stinodego opened this issue Feb 9, 2023 · 0 comments · May be fixed by #126
Open

Incorrect stub file causes type checking error #125

stinodego opened this issue Feb 9, 2023 · 0 comments · May be fixed by #126

Comments

@stinodego
Copy link

stinodego commented Feb 9, 2023 •
edited
Loading

The new release of mypy 1.0.0 exposed a problem in the typing of this module.

The issue

Consider the following code:

from backports.zoneinfo import ZoneInfo

tzinfo = ZoneInfo("Pacific/Rarotonga")  # Type error

Type-checking this with mypy will result in the following error:

repro.py:3: error: Cannot instantiate abstract class "ZoneInfo" with abstract attributes "dst", "tzname" and "utcoffset"  [abstract]

The solution

After some investigation, I noticed that the type stub file of backports.zoneinfo does not contain type information for the abstract methods of ZoneInfo. The solution would be to add types for these methods.

I don't mind making a PR for this if you want to make a new release including this fix. Let me know.

The workaround

A workaround for dealing with this issue is to import ZoneInfo from the submodule directly:

from backports.zoneinfo._zoneinfo import ZoneInfo

tzinfo = ZoneInfo("Pacific/Rarotonga")  # OK
This was referenced Feb 9, 2023
Merged
Closed
andersk added a commit to andersk/zoneinfo that referenced this issue Mar 4, 2023
@andersk
Stub methods for abstract tzinfo to allow usage with mypy 1.0.0
f9687ab 
Fixes pganssle#125.  Ported from:

python/typeshed@de0b366

Signed-off-by: Anders Kaseorg <[email protected]>
@andersk andersk linked a pull request Mar 4, 2023 that will close this issue
Open
andersk added a commit to andersk/zoneinfo that referenced this issue Mar 8, 2023
@andersk
Stub methods for abstract tzinfo to allow usage with mypy 1.0.0
abb4903 
Fixes pganssle#125.  Ported from:

python/typeshed@de0b366

Signed-off-by: Anders Kaseorg <[email protected]>
pganssle pushed a commit to andersk/zoneinfo that referenced this issue Mar 10, 2023
@andersk @pganssle
Stub methods for abstract tzinfo to allow usage with mypy 1.0.0
6b73942 
Fixes pganssle#125.  Ported from:

python/typeshed@de0b366

Signed-off-by: Anders Kaseorg <[email protected]>
@stinodego stinodego mentioned this issue Apr 3, 2023
Closed
@stinodego stinodego mentioned this issue Jul 2, 2023
Merged
sbrudenell added a commit to sbrudenell/btrfs2s3 that referenced this issue Jun 26, 2024
@sbrudenell
clean up dependencies for mypy pre-commit hook
4e87a3c 
among other things, I hadn't realized that types-all was deprecated.

this change exposed pganssle/zoneinfo#125. I
have no explanation for why it wasn't exposed before, but rather than
investigate this I'll choose to just fix it and assume it was previously
shadowed by something in types-all.
sbrudenell added a commit to sbrudenell/btrfs2s3 that referenced this issue Jun 26, 2024
@sbrudenell
clean up dependencies for mypy pre-commit hook
eed2a98 
among other things, I hadn't realized that types-all was deprecated.

this change exposed pganssle/zoneinfo#125. I
have no explanation for why it wasn't exposed before, but rather than
investigate this I'll choose to just fix it and assume it was previously
shadowed by something in types-all.
sbrudenell added a commit to sbrudenell/btrfs2s3 that referenced this issue Jun 26, 2024
@sbrudenell
clean up dependencies for mypy pre-commit hook
60da68d 
among other things, I hadn't realized that types-all was deprecated.

this change exposed pganssle/zoneinfo#125. I
have no explanation for why it wasn't exposed before, but rather than
investigate this I'll choose to just fix it and assume it was previously
shadowed by something in types-all.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stub methods for abstract tzinfo to allow usage with mypy 1.0.0 andersk/zoneinfo
1 participant
@stinodego