Skip to content

Conversation

@khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Dec 23, 2025

Reverts #6336

Background

Since we are using ECS external controller, force new deployment is not supported. The below error is returned from ECS API service

 Cannot force a new deployment on services with a EXTERNAL deployment controller.

@khanhtc1202 khanhtc1202 requested a review from a team as a code owner December 23, 2025 04:44
This reverts commit cac601e.

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@khanhtc1202 khanhtc1202 force-pushed the revert-6336-ecs-support-force-new-deployment branch from ff251e9 to 5790917 Compare December 23, 2025 04:45
@khanhtc1202 khanhtc1202 enabled auto-merge (squash) December 23, 2025 04:48
@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.77%. Comparing base (3fc8a15) to head (5790917).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/piped/executor/ecs/ecs.go 0.00% 6 Missing ⚠️
pkg/app/piped/executor/ecs/deploy.go 0.00% 1 Missing ⚠️
pkg/app/piped/executor/ecs/rollback.go 0.00% 1 Missing ⚠️
pkg/app/piped/platformprovider/ecs/client.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6384      +/-   ##
==========================================
- Coverage   28.85%   28.77%   -0.09%     
==========================================
  Files         560      541      -19     
  Lines       59993    58581    -1412     
==========================================
- Hits        17313    16857     -456     
+ Misses      41359    40433     -926     
+ Partials     1321     1291      -30     
Flag Coverage Δ
. 23.28% <0.00%> (+<0.01%) ⬆️
.-pkg-app-pipedv1-plugin-analysis 32.64% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 58.67% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.63% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 54.83% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform ?
.-pkg-app-pipedv1-plugin-wait 33.92% <ø> (ø)
.-pkg-app-pipedv1-plugin-waitapproval ?
.-pkg-plugin-sdk 50.34% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview ?
.-tool-codegen-protoc-gen-auth ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@khanhtc1202 khanhtc1202 merged commit 39c5cf2 into master Dec 23, 2025
44 of 46 checks passed
@khanhtc1202 khanhtc1202 deleted the revert-6336-ecs-support-force-new-deployment branch December 23, 2025 04:55
@github-actions github-actions bot mentioned this pull request Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants