Support ecs quicksync force new deployment config #6336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #6336 +/- ##
==========================================
- Coverage 28.83% 28.81% -0.02%
==========================================
Files 560 560
Lines 59922 59937 +15
==========================================
- Hits 17277 17271 -6
- Misses 41324 41345 +21
Partials 1321 1321
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
t-kikuc
previously approved these changes
Nov 7, 2025
pkg/app/piped/executor/ecs/deploy.go
Outdated
| forceNewDeployment := e.appCfg.QuickSync.ForceNewDeployment | ||
|
|
||
| // Store force new deployment flag to metadata store. | ||
| e.Input.MetadataStore.Shared().Put(ctx, "force-new-deployment", strconv.FormatBool(forceNewDeployment)) |
Member
Author
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
t-kikuc
approved these changes
Nov 7, 2025
khanhtc1202
added a commit
that referenced
this pull request
Dec 23, 2025
This reverts commit cac601e.
khanhtc1202
added a commit
that referenced
this pull request
Dec 23, 2025
This reverts commit cac601e. Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
khanhtc1202
added a commit
that referenced
this pull request
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add ECS QuickSync forceNewDeployment config. The configuration would be like:
Why we need it:
It requires forcing a new deployment when updating the ECS service configuration from LaunchType to Capacity provider strategy. So, my plan is to support switching from launch type to capacity provider strategy on existing service by enabling force new deployment on the updated service in case of ECS quick sync deployment triggered.
Error message
Which issue(s) this PR fixes:
Follow PR #6331
Does this PR introduce a user-facing change?: