Skip to content

Conversation

@khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Dec 23, 2025

Reverts #6331

Background

Follow PR #6384. We need to find an alternative way to support the capacity provider strategy, as enabling the ECS API to force the creation of a new deployment is necessary to make it happen.

InvalidParameterException: When switching from launch type to capacity provider strategy on an existing service, or making a change to a capacity provider strategy on a service that is already using one, you must force a new deployment.

@khanhtc1202 khanhtc1202 requested a review from a team as a code owner December 23, 2025 04:57
This reverts commit a2e18d7.

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@khanhtc1202 khanhtc1202 force-pushed the revert-6331-ecs-support-capacity-provider-strategy branch from 35782be to d531800 Compare December 23, 2025 04:58
@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 28.87%. Comparing base (39c5cf2) to head (d531800).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/piped/platformprovider/ecs/client.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6385      +/-   ##
==========================================
+ Coverage   28.81%   28.87%   +0.06%     
==========================================
  Files         556      560       +4     
  Lines       59849    59955     +106     
==========================================
+ Hits        17245    17313      +68     
- Misses      41290    41321      +31     
- Partials     1314     1321       +7     
Flag Coverage Δ
. 23.29% <0.00%> (+0.01%) ⬆️
.-pkg-app-pipedv1-plugin-analysis 32.64% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 58.67% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.63% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 54.83% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 38.65% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 33.92% <ø> (ø)
.-pkg-app-pipedv1-plugin-waitapproval 52.71% <ø> (?)
.-pkg-plugin-sdk 50.34% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.51% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@khanhtc1202 khanhtc1202 merged commit 937b8ef into master Dec 23, 2025
60 of 63 checks passed
@khanhtc1202 khanhtc1202 deleted the revert-6331-ecs-support-capacity-provider-strategy branch December 23, 2025 05:35
@github-actions github-actions bot mentioned this pull request Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants