Fix part of lint/go errors (stylecheck)

[karamaru-alpha]

What this PR does / why we need it:

Fix part of errors which make lint/go returns (stylecheck).

stylecheck lint errors

$ make lint/go | grep -e "(stylecheck)"
docs/main.go:48:38: ST1013: should use constant http.StatusTemporaryRedirect instead of numeric literal 307 (stylecheck)
pkg/app/piped/trigger/trigger.go:180:3: ST1003: var repoId should be repoID (stylecheck)
pkg/app/server/grpcapi/piped_api.go:45:6: ST1003: type pipedApiApplicationStore should be pipedAPIApplicationStore (stylecheck)
pkg/app/server/grpcapi/piped_api.go:54:6: ST1003: type pipedApiDeploymentStore should be pipedAPIDeploymentStore (stylecheck)
pkg/app/server/grpcapi/piped_api.go:66:6: ST1003: type pipedApiDeploymentChainStore should be pipedAPIDeploymentChainStore (stylecheck)
pkg/app/server/grpcapi/piped_api.go:71:6: ST1003: type pipedApiPipedStore should be pipedAPIPipedStore (stylecheck)
pkg/app/server/grpcapi/piped_api.go:76:6: ST1003: type pipedApiEventStore should be pipedAPIEventStore (stylecheck)
pkg/app/server/grpcapi/web_api.go:51:6: ST1003: type webApiApplicationStore should be webAPIApplicationStore (stylecheck)
pkg/app/server/grpcapi/web_api.go:61:6: ST1003: type webApiDeploymentChainStore should be webAPIDeploymentChainStore (stylecheck)
pkg/app/server/grpcapi/web_api.go:66:6: ST1003: type webApiDeploymentStore should be webAPIDeploymentStore (stylecheck)
pkg/app/server/grpcapi/web_api.go:71:6: ST1003: type webApiPipedStore should be webAPIPipedStore (stylecheck)
pkg/app/server/grpcapi/web_api.go:83:6: ST1003: type webApiProjectStore should be webAPIProjectStore (stylecheck)
pkg/app/server/grpcapi/web_api.go:97:6: ST1003: type webApiEventStore should be webAPIEventStore (stylecheck)
pkg/app/server/grpcapi/web_api.go:101:6: ST1003: type webApiAPIKeyStore should be webAPIAPIKeyStore (stylecheck)
pkg/cli/app.go:33:5: ST1012: error var FlagParseErr should have name of the form ErrFoo (stylecheck)
pkg/config/analysis_template.go:26:2: ST1003: struct field HTTPs should be HTTPS (stylecheck)
pkg/config/application.go:219:2: ST1003: struct field Id should be ID (stylecheck)
pkg/config/application.go:255:2: ST1003: struct field Id should be ID (stylecheck)
pkg/config/application.go:443:2: ST1003: struct field Https should be HTTPS (stylecheck)
pkg/config/control_plane.go:55:2: ST1003: struct field Id should be ID (stylecheck)
pkg/model/application.go:92:27: ST1016: methods on the same type should have the same receiver name (seen 1x "k", 1x "x") (stylecheck)

List of remaining errors

• stylecheck
• gocritic
• errcheck
• goerr113
• typecheck
• gosec
• deadcode, ineffassign Fix part of lint/go errors (deadcode, ineffassign, depguard) #4624
• misspell, depguard, unconvert Fix part of lint/go errors (misspell, depguard, unconvert) #4621
• goimports, gosimple, staticcheck Fix part of lint/go errors (goimports, staticcheck, gosimple) #4622

Which issue(s) this PR fixes:

Part of #4566

Does this PR introduce a user-facing change?:

• How are users affected by this change:
• Is this breaking change:
• How to migrate (if breaking change):

[khanhtc1202]

Nice, just left a nits 🙌

[khanhtc1202]

Why do we need to update this?

[karamaru-alpha]

To resolve this error.

pkg/model/application.go:92:27: ST1016: methods on the same type should have the same receiver name (seen 1x "k", 1x "x") (stylecheck)

By the way, I reconsider the naming "k" is more appropriate than "x", so I unify the naming with "k" and use a value receiver for the enum by following other implementations.

Could you check this, please?

e810370

[khanhtc1202]

Got it, I don't have strong opinion on this but looks like ak could be more like go 😄 Anw, thanks 👍

[karamaru-alpha]

I see. Fixed it👍

5bb575b

[codecov]

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (e5b77f7) 30.57% compared to head (5bb575b) 30.57%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4638   +/-   ##
=======================================
  Coverage   30.57%   30.57%           
=======================================
  Files         221      221           
  Lines       25937    25937           
=======================================
  Hits         7929     7929           
  Misses      17360    17360           
  Partials      648      648           

Files	Coverage Δ
pkg/app/server/grpcapi/piped_api.go	3.33% <ø> (ø)
pkg/config/analysis_template.go	53.84% <ø> (ø)
pkg/config/application.go	42.41% <100.00%> (ø)
pkg/insight/insightstore/deployment_store.go	50.42% <100.00%> (ø)
pkg/model/application.go	79.66% <100.00%> (ø)
pkg/app/piped/planner/kubernetes/pipeline.go	67.44% <75.00%> (ø)
pkg/app/server/grpcapi/web_api.go	4.24% <0.00%> (ø)
pkg/cli/app.go	53.70% <0.00%> (ø)
pkg/insight/application.go	0.00% <0.00%> (ø)
pkg/insight/deployment.go	0.00% <0.00%> (ø)
... and 5 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[khanhtc1202]

Thanks 🥇