Reduce `make lint/go` execution time by adding the GOCACHE environment variable #4628

karamaru-alpha · 2023-10-24T12:34:28Z

What this PR does / why we need it:

Add the GOCACHE environment variable to make go/lint in order to reduce command execution time.
Add verbose option(-v) to make go/lint in order to make it easier to see lint's progress.
Change timeout setting name and extend its duration.

With the cache in effect, I have confirmed that the "make go/lint" execution time has decreased from 5.1m to 1.7m on my PC 🎉

Benchmark:

Execute with no cache. 6.1m

$ time make lint/go
-> cpu 6:10.38 total

Execute with lint cache(GOLANGCI_LINT_CACHE). 5.1m

$ time make lint/go
...
INFO [loader] Go packages loading at mode 575 (compiled_files|exports_file|name|types_sizes|deps|files|imports) took 4m2.312266987s
...
-> cpc 5:06.65 total

Execute with lint cache(GOLANGCI_LINT_CACHE) and go build cache(GOCACHE). 1.7m 🎉

$ time make lint/go
...
INFO [loader] Go packages loading at mode 575 (deps|exports_file|files|types_sizes|compiled_files|name|imports) took 37.603624725s
...
-> cpu 1:43.64 total

cf. golangci/golangci-lint#1004

Signed-off-by: karamaru-alpha <[email protected]>

karamaru-alpha · 2023-10-24T12:41:36Z

.golangci.yml

@@ -1,5 +1,5 @@
 run:
-  deadline: 5m
+  timeout: 15m


According to Rename deadline option to timeout and mark deadline as deprecated golangci/golangci-lint#793, "deadline" is deprecated, so change it to "timeout".

If there is no cache, the command may exceed 5 minutes, so extend the timeout period to 15minutes with time to spare.

codecov · 2023-10-24T13:25:45Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d427bab) 29.99% compared to head (957ac1e) 29.99%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4628   +/-   ##
=======================================
  Coverage   29.99%   29.99%           
=======================================
  Files         221      221           
  Lines       25937    25937           
=======================================
  Hits         7781     7781           
  Misses      17510    17510           
  Partials      646      646

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kentakozuka

LGTM 🎉

…t variable (pipe-cd#4628) * Add GOCACHE env to lint/go Signed-off-by: karamaru-alpha <[email protected]> * Add verbose flag to lint/go Signed-off-by: karamaru-alpha <[email protected]> * Change timeout golangci.yml Signed-off-by: karamaru-alpha <[email protected]> --------- Signed-off-by: karamaru-alpha <[email protected]> Signed-off-by: moko-poi <[email protected]>

…t variable (pipe-cd#4628) * Add GOCACHE env to lint/go Signed-off-by: karamaru-alpha <[email protected]> * Add verbose flag to lint/go Signed-off-by: karamaru-alpha <[email protected]> * Change timeout golangci.yml Signed-off-by: karamaru-alpha <[email protected]> --------- Signed-off-by: karamaru-alpha <[email protected]>

…t variable (#4628) * Add GOCACHE env to lint/go Signed-off-by: karamaru-alpha <[email protected]> * Add verbose flag to lint/go Signed-off-by: karamaru-alpha <[email protected]> * Change timeout golangci.yml Signed-off-by: karamaru-alpha <[email protected]> --------- Signed-off-by: karamaru-alpha <[email protected]>

#4628 #4629 #4631 #4632 #4633 #4637 #4638 #4641 #4648 #4650 #4656 #4658 #4662 #4666 (#4669) * Bump golang.org/x/net from 0.7.0 to 0.17.0 in /tool/actions-plan-preview (#4611) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.7.0 to 0.17.0. - [Commits](golang/net@v0.7.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump golang.org/x/net from 0.7.0 to 0.17.0 in /tool/actions-gh-release (#4612) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.7.0 to 0.17.0. - [Commits](golang/net@v0.7.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Khanh Tran <[email protected]> * Bump golang.org/x/net from 0.8.0 to 0.17.0 (#4613) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.8.0 to 0.17.0. - [Commits](golang/net@v0.8.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @babel/traverse from 7.14.7 to 7.23.2 in /web (#4619) * Fix part of lint/go errors (misspell, depguard, unconvert) (#4621) * Fix lint/go errors (misspell) Signed-off-by: karamaru-alpha <[email protected]> * Fix lint/go errors (depguard) Signed-off-by: karamaru-alpha <[email protected]> * Fix lint/go errors (unconvert) Signed-off-by: karamaru-alpha <[email protected]> --------- Signed-off-by: karamaru-alpha <[email protected]> * Fix part of lint/go errors (goimports, staticcheck, gosimple) (#4622) * Fix lint/go errors (goimport) Signed-off-by: karamaru-alpha <[email protected]> * Fix lint/go errors (staticcheck) Signed-off-by: karamaru-alpha <[email protected]> * Fix lint/go errors (gosimple) Signed-off-by: karamaru-alpha <[email protected]> * Fix lint/go errors (gosimple) Signed-off-by: karamaru-alpha <[email protected]> * Fix return error by function Signed-off-by: karamaru-alpha <[email protected]> --------- Signed-off-by: karamaru-alpha <[email protected]> * Fix part of lint/go errors (deadcode, ineffassign, depguard) (#4624) * Ignore mannwhitney from golangci-lint Signed-off-by: karamaru-alpha <[email protected]> * Fix lint/go errors (deadcode) Signed-off-by: karamaru-alpha <[email protected]> * Fix lint/go errors (depguard) Signed-off-by: karamaru-alpha <[email protected]> --------- Signed-off-by: karamaru-alpha <[email protected]> * Add tests to terraform platform provider (#4625) Signed-off-by: Kenta Kozuka <[email protected]> * Add tests to apikey model (#4626) Signed-off-by: Kenta Kozuka <[email protected]> * Add tests to application model (#4627) Signed-off-by: Kenta Kozuka <[email protected]> * Reduce `make lint/go` execution time by adding the GOCACHE environment variable (#4628) * Add GOCACHE env to lint/go Signed-off-by: karamaru-alpha <[email protected]> * Add verbose flag to lint/go Signed-off-by: karamaru-alpha <[email protected]> * Change timeout golangci.yml Signed-off-by: karamaru-alpha <[email protected]> --------- Signed-off-by: karamaru-alpha <[email protected]> * Add tests to model/deployment (#4629) Signed-off-by: Kenta Kozuka <[email protected]> * Add tests to model/notificationevent (#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> * Add tests to model/deployment_chain (#4632) * Bump google.golang.org/grpc from 1.54.0 to 1.56.3 (#4633) * Bump google.golang.org/grpc from 1.54.0 to 1.56.3 Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.54.0 to 1.56.3. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.54.0...v1.56.3) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * Update grpc test version Signed-off-by: khanhtc1202 <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: khanhtc1202 <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: khanhtc1202 <[email protected]> * Fix lint/go errors (gocritic) (#4637) Signed-off-by: karamaru-alpha <[email protected]> * Fix part of lint/go errors (stylecheck) (#4638) * Fix lint/go errors (stylecheck) Signed-off-by: karamaru-alpha <[email protected]> * Remove nolint:stylecheck Signed-off-by: karamaru-alpha <[email protected]> * Change method reveiver name Signed-off-by: karamaru-alpha <[email protected]> * Change receiver name k to ak Signed-off-by: karamaru-alpha <[email protected]> --------- Signed-off-by: karamaru-alpha <[email protected]> * Bump github.com/docker/docker (#4641) * Make actions plan preview handle timeout option (#4648) * Format and make tests pass in tool/actions-plan-preview Signed-off-by: mi11km <[email protected]> * Use --piped-handle-timeout to make the timeout arg activate Signed-off-by: mi11km <[email protected]> * Add tests to model/notificationevent (#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: mi11km <[email protected]> * add piped-handle-timeout(input args) Signed-off-by: mi11km <[email protected]> --------- Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Khanh Tran <[email protected]> * Fix panic error in ListDeployments API (#4650) * Update golangci-lint and fix lint errors (#4656) Signed-off-by: karamaru-alpha <[email protected]> * Send error comment before plan preview exit (#4658) * Send error comment before plan preview exit Signed-off-by: Takumaron <[email protected]> * Apply review commnet Signed-off-by: Takumaron <[email protected]> --------- Signed-off-by: Takumaron <[email protected]> * Handle plan preview workflow's error and exit with error status code (#4662) * Add a flag to skip running standalone task during deployment (#4666) * Add a flag to skip running standalone task during deployment Signed-off-by: Kenta Kozuka <[email protected]> * Fix docs Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: karamaru-alpha <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: mi11km <[email protected]> Signed-off-by: Takumaron <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: karamaru <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: khanhtc1202 <[email protected]> Co-authored-by: Masafumi Ikeyama <[email protected]> Co-authored-by: Seitaro Fujigaki <[email protected]> Co-authored-by: Kurosawa Takuma <[email protected]>

…t variable (pipe-cd#4628) * Add GOCACHE env to lint/go Signed-off-by: karamaru-alpha <[email protected]> * Add verbose flag to lint/go Signed-off-by: karamaru-alpha <[email protected]> * Change timeout golangci.yml Signed-off-by: karamaru-alpha <[email protected]> --------- Signed-off-by: karamaru-alpha <[email protected]> Signed-off-by: 鈴木優耀 <[email protected]>

karamaru-alpha added 3 commits October 24, 2023 21:04

Add GOCACHE env to lint/go

b5d6306

Signed-off-by: karamaru-alpha <[email protected]>

Add verbose flag to lint/go

68a67bb

Signed-off-by: karamaru-alpha <[email protected]>

Change timeout golangci.yml

957ac1e

Signed-off-by: karamaru-alpha <[email protected]>

github-actions bot added the area/build label Oct 24, 2023

karamaru-alpha commented Oct 24, 2023

View reviewed changes

karamaru-alpha marked this pull request as ready for review October 24, 2023 12:43

karamaru-alpha requested review from ffjlabo, kentakozuka, khanhtc1202 and nghialv as code owners October 24, 2023 12:43

karamaru-alpha changed the title ~~Faster make lint/go by adding the GOCACHE environment variable~~ Sped up make lint/go by adding the GOCACHE environment variable Oct 24, 2023

karamaru-alpha changed the title ~~Sped up make lint/go by adding the GOCACHE environment variable~~ Reduce make lint/go execution time by adding the GOCACHE environment variable Oct 24, 2023

kentakozuka approved these changes Oct 24, 2023

View reviewed changes

kentakozuka merged commit 7278abe into pipe-cd:master Oct 24, 2023

ffjlabo mentioned this pull request Nov 13, 2023

Cherry-pick #4611 #4612 #4613 #4619 #4621 #4622 #4624 #4625 #4626 #4627 #4628 #4629 #4631 #4632 #4633 #4637 #4638 #4641 #4648 #4650 #4656 #4658 #4662 #4666 #4669

Merged

github-actions bot mentioned this pull request Dec 1, 2023

Release v0.45.4 #4697

Merged

github-actions bot mentioned this pull request Feb 6, 2024

Release v0.46.0 #4775

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Reduce `make lint/go` execution time by adding the GOCACHE environment variable #4628

Reduce `make lint/go` execution time by adding the GOCACHE environment variable #4628

Uh oh!

karamaru-alpha commented Oct 24, 2023 •

edited

Loading

Uh oh!

karamaru-alpha Oct 24, 2023 •

edited

Loading

Uh oh!

codecov bot commented Oct 24, 2023

Uh oh!

kentakozuka left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Reduce make lint/go execution time by adding the GOCACHE environment variable #4628

Reduce make lint/go execution time by adding the GOCACHE environment variable #4628

Uh oh!

Conversation

karamaru-alpha commented Oct 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

karamaru-alpha Oct 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Oct 24, 2023

Codecov Report

Uh oh!

kentakozuka left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Reduce `make lint/go` execution time by adding the GOCACHE environment variable #4628

Reduce `make lint/go` execution time by adding the GOCACHE environment variable #4628

karamaru-alpha commented Oct 24, 2023 •

edited

Loading

karamaru-alpha Oct 24, 2023 •

edited

Loading