Add tests to model/deployment_chain #4632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

khanhtc1202 merged 2 commits into pipe-cd:master from kentakozuka:test-pkg-model-deployment-chain

Nov 6, 2023

Member

kentakozuka commented Oct 25, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

How are users affected by this change:
Is this breaking change:
How to migrate (if breaking change):

kentakozuka requested review from ffjlabo, khanhtc1202 and nghialv as code owners

October 25, 2023 13:42

github-actions bot added the area/go label

codecov bot commented Oct 25, 2023 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0dcf710) 30.55% compared to head (daf20c7) 30.79%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4632      +/-   ##
==========================================
+ Coverage   30.55%   30.79%   +0.23%     
==========================================
  Files         221      221              
  Lines       25937    25937              
==========================================
+ Hits         7925     7987      +62     
+ Misses      17364    17300      -64     
- Partials      648      650       +2

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ffjlabo reviewed

View reviewed changes

Member

ffjlabo left a comment

Thank you for adding unit tests! It's so helpful!
I added some comments!

pkg/model/deployment_chain_test.go

Comment on lines 113 to 118

    
              func TestListAllInChainApplicationDeploymentsMap(t *testing.T) {

              	dc := &DeploymentChain{

Member

ffjlabo Oct 26, 2023

Let's add t.Parallel !

pkg/model/deployment_chain_test.go

Comment on lines 153 to 159

    
              func TestListAllInChainApplications(t *testing.T) {

              	dc := &DeploymentChain{

Member

ffjlabo Oct 26, 2023

also add t.Parallel 👍

pkg/model/deployment_chain_test.go

Comment on lines 195 to 203

    
              func TestIsCompleted(t *testing.T) {

              	tests := []struct {

              		name   string

Member

ffjlabo Oct 26, 2023

also add t.Parallel 👍

pkg/model/deployment_chain_test.go

Comment on lines 236 to 246

    
              func TestDesiredStatus(t *testing.T) {

              	tests := []struct {

Member

ffjlabo Oct 26, 2023

also add t.Parallel 👍

pkg/model/deployment_chain_test.go

Comment on lines 300 to 314

    
              func TestGetNodeByDeploymentID(t *testing.T) {

              	block := &ChainBlock{

              		Nodes: []*ChainNode{

Member

ffjlabo Oct 26, 2023

also add t.Parallel 👍

pkg/model/deployment_chain_test.go

Comment on lines 227 to 238

    
              	for _, tt := range tests {

              		t.Run(tt.name, func(t *testing.T) {

              			b := &ChainBlock{Status: tt.status}

Member

ffjlabo Oct 26, 2023

it should be better to add t.Parallel and tt := tt 👍

pkg/model/deployment_chain_test.go

Comment on lines 340 to 357

    
              	for _, tt := range tests {

              		t.Run(tt.name, func(t *testing.T) {

              			gotNode, err := block.GetNodeByDeploymentID(tt.deploymentID)

Member

ffjlabo Oct 26, 2023

Also here

it should be better to add t.Parallel and tt := tt 👍

pkg/model/deployment_chain_test.go

Comment on lines 291 to 305

    
              	for _, tt := range tests {

              		t.Run(tt.name, func(t *testing.T) {

              			gotDesired := tt.block.DesiredStatus()

Member

ffjlabo Oct 26, 2023

Also here

it should be better to add t.Parallel and tt := tt 👍

kentakozuka added 2 commits

November 1, 2023 12:25


          Add tests to model/deployment_chain

e8bcc29

Signed-off-by: Kenta Kozuka <[email protected]>


          Add Parallel()

daf20c7

Signed-off-by: Kenta Kozuka <[email protected]>

kentakozuka force-pushed the test-pkg-model-deployment-chain branch from a4e7e4d to daf20c7 Compare

November 1, 2023 03:25

Member Author

kentakozuka commented Nov 1, 2023

@ffjlabo Fixed 👍

khanhtc1202 approved these changes

View reviewed changes

Member

khanhtc1202 left a comment

🚀

khanhtc1202 merged commit b42ab23 into pipe-cd:master

ffjlabo mentioned this pull request

Cherry-pick #4611 #4612 #4613 #4619 #4621 #4622 #4624 #4625 #4626 #4627 #4628 #4629 #4631 #4632 #4633 #4637 #4638 #4641 #4648 #4650 #4656 #4658 #4662 #4666 #4669

Merged

ffjlabo pushed a commit that referenced this pull request


          Add tests to model/deployment_chain (#4632)

11c66a0

khanhtc1202 added a commit that referenced this pull request

#4628 #4629 #4631 #4632 #4633 #4637 #4638 #4641 #4648 #4650 #4656 #4658 #4662 #4666 (#4669)

* Bump golang.org/x/net from 0.7.0 to 0.17.0 in /tool/actions-plan-preview (#4611)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.7.0 to 0.17.0.
- [Commits](golang/net@v0.7.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump golang.org/x/net from 0.7.0 to 0.17.0 in /tool/actions-gh-release (#4612)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.7.0 to 0.17.0.
- [Commits](golang/net@v0.7.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Khanh Tran <[email protected]>

* Bump golang.org/x/net from 0.8.0 to 0.17.0 (#4613)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.8.0 to 0.17.0.
- [Commits](golang/net@v0.8.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump @babel/traverse from 7.14.7 to 7.23.2 in /web (#4619)

* Fix part of lint/go errors (misspell, depguard, unconvert) (#4621)

* Fix lint/go errors (misspell)

Signed-off-by: karamaru-alpha <[email protected]>

* Fix lint/go errors (depguard)

Signed-off-by: karamaru-alpha <[email protected]>

* Fix lint/go errors (unconvert)

Signed-off-by: karamaru-alpha <[email protected]>

---------

Signed-off-by: karamaru-alpha <[email protected]>

* Fix part of lint/go errors (goimports, staticcheck, gosimple) (#4622)

* Fix lint/go errors (goimport)

Signed-off-by: karamaru-alpha <[email protected]>

* Fix lint/go errors (staticcheck)

Signed-off-by: karamaru-alpha <[email protected]>

* Fix lint/go errors (gosimple)

Signed-off-by: karamaru-alpha <[email protected]>

* Fix lint/go errors (gosimple)

Signed-off-by: karamaru-alpha <[email protected]>

* Fix return error by function

Signed-off-by: karamaru-alpha <[email protected]>

---------

Signed-off-by: karamaru-alpha <[email protected]>

* Fix part of lint/go errors (deadcode, ineffassign, depguard) (#4624)

* Ignore mannwhitney from golangci-lint

Signed-off-by: karamaru-alpha <[email protected]>

* Fix lint/go errors (deadcode)

Signed-off-by: karamaru-alpha <[email protected]>

* Fix lint/go errors (depguard)

Signed-off-by: karamaru-alpha <[email protected]>

---------

Signed-off-by: karamaru-alpha <[email protected]>

* Add tests to terraform platform provider (#4625)

Signed-off-by: Kenta Kozuka <[email protected]>

* Add tests to apikey model (#4626)

Signed-off-by: Kenta Kozuka <[email protected]>

* Add tests to application model (#4627)

Signed-off-by: Kenta Kozuka <[email protected]>

* Reduce `make lint/go` execution time by adding the GOCACHE environment variable (#4628)

* Add GOCACHE env to lint/go

Signed-off-by: karamaru-alpha <[email protected]>

* Add verbose flag to lint/go

Signed-off-by: karamaru-alpha <[email protected]>

* Change timeout golangci.yml

Signed-off-by: karamaru-alpha <[email protected]>

---------

Signed-off-by: karamaru-alpha <[email protected]>

* Add tests to model/deployment (#4629)

Signed-off-by: Kenta Kozuka <[email protected]>

* Add tests to model/notificationevent (#4631)

* Add tests to model/notificationevent

Signed-off-by: Kenta Kozuka <[email protected]>

* Add Parallel()

Signed-off-by: Kenta Kozuka <[email protected]>

---------

Signed-off-by: Kenta Kozuka <[email protected]>

* Add tests to model/deployment_chain (#4632)

* Bump google.golang.org/grpc from 1.54.0 to 1.56.3 (#4633)

* Bump google.golang.org/grpc from 1.54.0 to 1.56.3

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.54.0 to 1.56.3.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.54.0...v1.56.3)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update grpc test version

Signed-off-by: khanhtc1202 <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: khanhtc1202 <[email protected]>

* Fix lint/go errors (gocritic) (#4637)

Signed-off-by: karamaru-alpha <[email protected]>

* Fix part of lint/go errors (stylecheck)  (#4638)

* Fix lint/go errors (stylecheck)

Signed-off-by: karamaru-alpha <[email protected]>

* Remove nolint:stylecheck

Signed-off-by: karamaru-alpha <[email protected]>

* Change method reveiver name

Signed-off-by: karamaru-alpha <[email protected]>

* Change receiver name k to ak

Signed-off-by: karamaru-alpha <[email protected]>

---------

Signed-off-by: karamaru-alpha <[email protected]>

* Bump github.com/docker/docker (#4641)

* Make actions plan preview handle timeout option (#4648)

* Format and make tests pass in tool/actions-plan-preview

Signed-off-by: mi11km <[email protected]>

* Use --piped-handle-timeout to make the timeout arg activate

Signed-off-by: mi11km <[email protected]>

* Add tests to model/notificationevent (#4631)

* Add tests to model/notificationevent

Signed-off-by: Kenta Kozuka <[email protected]>

* Add Parallel()

Signed-off-by: Kenta Kozuka <[email protected]>

---------

Signed-off-by: Kenta Kozuka <[email protected]>
Signed-off-by: mi11km <[email protected]>

* add piped-handle-timeout(input args)

Signed-off-by: mi11km <[email protected]>

---------

Signed-off-by: mi11km <[email protected]>
Signed-off-by: Kenta Kozuka <[email protected]>
Co-authored-by: Kenta Kozuka <[email protected]>
Co-authored-by: Khanh Tran <[email protected]>

* Fix panic error in ListDeployments API (#4650)

* Update golangci-lint and fix lint errors (#4656)

Signed-off-by: karamaru-alpha <[email protected]>

* Send error comment before plan preview exit (#4658)

* Send error comment before plan preview exit

Signed-off-by: Takumaron <[email protected]>

* Apply review commnet

Signed-off-by: Takumaron <[email protected]>

---------

Signed-off-by: Takumaron <[email protected]>

* Handle plan preview workflow's error and exit with error status code (#4662)

* Add a flag to skip running standalone task during deployment (#4666)

* Add a flag to skip running standalone task during deployment

Signed-off-by: Kenta Kozuka <[email protected]>

* Fix docs

Signed-off-by: Kenta Kozuka <[email protected]>

---------

Signed-off-by: Kenta Kozuka <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: karamaru-alpha <[email protected]>
Signed-off-by: Kenta Kozuka <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: mi11km <[email protected]>
Signed-off-by: Takumaron <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Khanh Tran <[email protected]>
Co-authored-by: karamaru <[email protected]>
Co-authored-by: Kenta Kozuka <[email protected]>
Co-authored-by: khanhtc1202 <[email protected]>
Co-authored-by: Masafumi Ikeyama <[email protected]>
Co-authored-by: Seitaro Fujigaki <[email protected]>
Co-authored-by: Kurosawa Takuma <[email protected]>

github-actions bot mentioned this pull request

Release v0.45.4 #4697

Merged

sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request


          Add tests to model/deployment_chain (pipe-cd#4632)

6927b17

sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request


          Add tests to model/deployment_chain (pipe-cd#4632)

29464a3

github-actions bot mentioned this pull request

Release v0.46.0 #4775

Merged

sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request


          Add tests to model/deployment_chain (pipe-cd#4632)

2a2b7e5

Signed-off-by: 鈴木 優耀 <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels