Skip to content

Conversation

@knanao
Copy link
Member

@knanao knanao commented Apr 12, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@khanhtc1202
Copy link
Member

should we update docs in docs-dev/ and docs/ as well?

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.69%. This pull request does not change code coverage.

@knanao
Copy link
Member Author

knanao commented Apr 12, 2022

@khanhtc1202
docs-dev/ has already been updated by #3518.
but hasn't run make sync-stable-docs yet. that's why let me run it.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.69%. This pull request does not change code coverage.

@khanhtc1202
Copy link
Member

I see, nice catch 👍
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants