Skip to content

Add feature to restart piped via web console #3698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Szarny wants to merge 16 commits into from
Closed

Add feature to restart piped via web console #3698

Szarny wants to merge 16 commits into from

Conversation

@Szarny
Copy link
Contributor

@Szarny Szarny commented May 31, 2022 •
edited
Loading

What this PR does / why we need it:

Add feature to restart piped via web console.

How to use this feature

  1. Activate PipeCD control plane and Piped (using launcher).

  2. After your Piped is activated, select the Restart item from the Piped settings menu.
    スクリーンショット 2022-05-31 15 41 28

  3. The following log message is output from Piped.

LAUNCHER: will relaunch a new Piped because a restart request was sent
  1. You can confirm its restart by looking at the Started At column in the web console.
    スクリーンショット 2022-05-31 15 43 41

Which issue(s) this PR fixes:

Fixes #3524

Does this PR introduce a user-facing change?:

Able to restart Piped via web console

@Szarny Szarny requested a review from nghialv as a code owner May 31, 2022 05:55
@Szarny Szarny self-assigned this May 31, 2022
@Szarny Szarny requested review from khanhtc1202 and knanao as code owners May 31, 2022 05:55
@Szarny Szarny marked this pull request as draft May 31, 2022 05:56
@Szarny
Copy link
Contributor Author

Szarny commented May 31, 2022

/wip

@Szarny
Copy link
Contributor Author

Szarny commented May 31, 2022

now it's ready for review!

@Szarny Szarny marked this pull request as ready for review May 31, 2022 07:01
@nghialv
Copy link
Member

nghialv commented May 31, 2022 •
edited by khanhtc1202
Loading

@Szarny Great work!

As our conventions, I recommend breaking this huge PR into some smaller PRs to be more readable.
For example, instead of this, we can have:

  • a PR to add the definition of gRPC
  • a PR to implement the API
  • a PR to implement the restart in Piped
  • a PR to update the web console

@Szarny
Copy link
Contributor Author

Szarny commented May 31, 2022

I will divide this PR into some smaller ones 🙏

@nghialv
Copy link
Member

nghialv commented Jun 1, 2022

I will divide this PR into some smaller ones 🙏

Thank you.

@Szarny Szarny marked this pull request as draft June 1, 2022 08:23
Tsubasa Umeuchi added 2 commits June 1, 2022 18:02
Merge branch 'master' into feature/3534-restart-piped
b8ac218 
# Conflicts:
#	pkg/app/server/grpcapi/piped_api.go
#	pkg/app/server/service/pipedservice/service.pb.go
#	pkg/datastore/datastoretest/datastore.mock.go
#	pkg/datastore/pipedstore.go
#	pkg/model/piped.pb.go
link break line
b4d90be
@Szarny Szarny changed the base branch from master to feature/3534-restart-piped-master June 1, 2022 09:05
@Szarny Szarny changed the base branch from feature/3534-restart-piped-master to master June 1, 2022 09:05
@Szarny
Copy link
Contributor Author

Szarny commented Jun 1, 2022

Move to new PR

@Szarny Szarny closed this Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nghialv nghialv Awaiting requested review from nghialv

@khanhtc1202 khanhtc1202 Awaiting requested review from khanhtc1202

@knanao knanao Awaiting requested review from knanao

Assignees

@Szarny Szarny

Labels

area/api area/go area/piped area/server area/web do-not-merge/wip

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Szarny @nghialv