Skip to content

Conversation

@knanao
Copy link
Member

@knanao knanao commented Apr 11, 2022

What this PR does / why we need it:
#3515

Which issue(s) this PR fixes:

Fixes #3515

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.64%. This pull request increases coverage by 0.02%.

File Function Base Head Diff
pkg/config/piped.go NotificationReceiverWebhook.LoadSignatureValue -- 80.00% +80.00%
pkg/app/piped/notifier/webhook.go webhook.sendEvent 0.00% 0.00% +0.00%

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.64%. This pull request increases coverage by 0.02%.

File Function Base Head Diff
pkg/config/piped.go NotificationReceiverWebhook.LoadSignatureValue -- 80.00% +80.00%
pkg/app/piped/notifier/webhook.go webhook.sendEvent 0.00% 0.00% +0.00%

@nghialv
Copy link
Member

nghialv commented Apr 11, 2022

Nice improvement.
/lgtm

@khanhtc1202
Copy link
Member

🙌
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support to enable webhook signatureValue to be mask from config file

5 participants