Skip to content

Fix wrong GitHub actions configuration #3369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pipecd-bot merged 1 commit into from
Mar 9, 2022
Merged

Fix wrong GitHub actions configuration #3369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/build-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,16 @@ jobs:
with:
go-version: '1.17.6'
- run: GOOS=linux GOARCH=amd64 go build -o artifacts/pipecd ./cmd/pipecd
Copy link
Member

@knanao knanao Mar 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it better which we create make command and call that command from CI.
However we've already used build for bazel, that's why, it's up to you whether replace it or not.

Copy link
Member Author

@nghialv nghialv Mar 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree about that.
I will refactor it later once confirmed that it works for our case.

- run: GOOS=linux GOARCH=amd64 go build -o artifacts/piped ./cmd/piped
- run: GOOS=linux GOARCH=amd64 go build -o artifacts/launcher ./cmd/launcher
- run: GOOS=linux GOARCH=amd64 go build -o artifacts/pipectl ./cmd/pipectl
- run: GOOS=linux GOARCH=amd64 go build -o artifacts/helloworld ./cmd/helloworld

test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-go@v2
with:
go-version: '1.17.6'
- run: go test ./...
- run: go test ./pkg/... ./cmd/...
2 changes: 1 addition & 1 deletion .github/workflows/publish-artifacts.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,4 @@ jobs:
with:
push: true
file: cmd/pipecd/Dockerfile
tags: pipecd:${{ github.ref_name }}
tags: ${{ env.REGISTRY }}/pipe-cd/pipecd:${{ github.ref_name }}