Skip to content

Conversation

@khanhtc1202
Copy link
Member

What this PR does / why we need it:

Add sqlServiceAccount as helm values. It will be used to enable connect from PipeCD workload to GCP Cloud SQL using Cloud SQL Auth proxy.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.08%. This pull request increases coverage by 0.01%.

File Function Base Head Diff
pkg/app/api/stagelogstore/filestore.go stageLogFileStore.Get 95.45% 95.65% +0.20%

@nghialv
Copy link
Member

nghialv commented Aug 17, 2021

/lgtm

gcsServiceAccount:
fileName: "gcs-service-account"
data: ""
sqlServiceAccount:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: cloudSQLServiceAccount? We're going to support the authentication for Amazon RDS, right?

Copy link
Member Author

@khanhtc1202 khanhtc1202 Aug 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to support the authentication for Amazon RDS, right?

Well, this change is for authorization, not authentication. And I've not looked at Amazon RDS connect method yet, but basically, we only support authentication RDS by username/password as we do for now, this service account is specific for connect to GCP cloud SQL only 🙏
About the name change, I will adopt your suggestion since it would be better to clearly mention that this is only for cloud SQL as you said 🙆‍♀️

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed by 48309ff 🙏

@pipecd-bot pipecd-bot removed the lgtm label Aug 17, 2021
@nakabonne
Copy link
Member

Thank you
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.08%. This pull request increases coverage by 0.01%.

File Function Base Head Diff
pkg/app/api/stagelogstore/filestore.go stageLogFileStore.Get 95.45% 95.65% +0.20%

@pipecd-bot pipecd-bot merged commit fec7289 into master Aug 17, 2021
@pipecd-bot pipecd-bot deleted the add-sql-service-account branch August 17, 2021 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants