Skip to content

Add sql service account #2361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pipecd-bot merged 2 commits into from
Aug 17, 2021
Merged

Add sql service account #2361

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fa1d06
Add sql service account
khanhtc1202 Aug 17, 2021
48309ff
Rename
khanhtc1202 Aug 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions manifests/pipecd/templates/secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ data:
{{- if .Values.secret.gcsServiceAccount.data }}
{{ .Values.secret.gcsServiceAccount.fileName }}: {{ .Values.secret.gcsServiceAccount.data | b64enc | quote }}
{{- end }}
{{- if .Values.secret.sqlServiceAccount.data }}
{{ .Values.secret.sqlServiceAccount.fileName }}: {{ .Values.secret.sqlServiceAccount.data | b64enc | quote }}
{{- end }}
{{- if .Values.secret.minioAccessKey.data }}
{{ .Values.secret.minioAccessKey.fileName }}: {{ .Values.secret.minioAccessKey.data | b64enc | quote }}
{{- end }}
Expand Down
3 changes: 3 additions & 0 deletions manifests/pipecd/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@ secret:
gcsServiceAccount:
fileName: "gcs-service-account"
data: ""
sqlServiceAccount:
Copy link
Member

@nakabonne nakabonne Aug 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: cloudSQLServiceAccount? We're going to support the authentication for Amazon RDS, right?

Copy link
Member Author

@khanhtc1202 khanhtc1202 Aug 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to support the authentication for Amazon RDS, right?

Well, this change is for authorization, not authentication. And I've not looked at Amazon RDS connect method yet, but basically, we only support authentication RDS by username/password as we do for now, this service account is specific for connect to GCP cloud SQL only 🙏
About the name change, I will adopt your suggestion since it would be better to clearly mention that this is only for cloud SQL as you said 🙆‍♀️

Copy link
Member Author

@khanhtc1202 khanhtc1202 Aug 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed by 48309ff 🙏

fileName: "sql-service-account"
data: ""
minioAccessKey:
fileName: "minio-access-key"
data: ""
Expand Down