Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: data cell + table comments #1279

Merged
merged 14 commits into from
Jun 27, 2023
Merged

feat: data cell + table comments #1279

merged 14 commits into from
Jun 27, 2023

Conversation

meowcodes
Copy link
Contributor

@meowcodes meowcodes commented Jun 23, 2023

Support for comment and comment threads
Each comment can be edited after posted
Each comment can be attached to a datadoc cell, or a whole table
When a cell is cloned or copied, the comment is not copied. When a cell is cut, the comment is moved
Support for reactions, like Slack
Support for richtext in comments

Screen.Recording.2023-06-21.at.4.58.27.PM.mov
Screenshot 2023-06-21 at 5 17 34 PM

AP-3433

meowcodes and others added 8 commits May 12, 2023 17:55
* ui: add ui

* update;

* update

* update

* update

* refactor const

* fix

* fix

* update
* ui: fix richtext not clearing

* fix popover position issue

* archive

* clean

* clean

* add table

* update

* update

* update

* update

* update
@meowcodes meowcodes requested review from czgu and jczhong84 June 23, 2023 17:51
package.json Outdated Show resolved Hide resolved
querybook/server/models/comment.py Show resolved Hide resolved
querybook/server/models/datadoc.py Outdated Show resolved Hide resolved
querybook/server/models/metastore.py Outdated Show resolved Hide resolved
@meowcodes meowcodes merged commit ccb032c into master Jun 27, 2023
@meowcodes meowcodes deleted the comment branch June 27, 2023 17:20
aidenprice pushed a commit to arrowtail-precision/querybook that referenced this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants