ui: add comment ui #1257
Merged
ui: add comment ui #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czgu
reviewed
Jun 1, 2023
querybook/migrations/versions/3d9f98ca7ec1_add_comment_feature.py
Outdated
Show resolved
Hide resolved
czgu
reviewed
Jun 3, 2023
| > | ||
| Editing Comment | ||
| </StyledText> | ||
| <div onClick={() => handleEditComment(null, initialCommentValue)}> |
There was a problem hiding this comment.
why not have a clear button for both editing comment and new comment use case? it could be a X button in the richtexteditor?
There was a problem hiding this comment.
idk if it really makes sense to have a clear for a regular comment. when would you ever use that? slack doesnt have one. neither does github
czgu
reviewed
Jun 5, 2023
czgu
approved these changes
Jun 5, 2023
meowcodes
added a commit
to meowcodes/querybook
that referenced
this pull request
Jun 23, 2023
* ui: add ui * update; * update * update * update * refactor const * fix * fix * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only UI/DOM code
next PR will be actions/reducers + typing will get cleaned up + moved