feat: enable archive comment + wrap up #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jczhong84
reviewed
Jun 21, 2023
czgu
reviewed
Jun 21, 2023
jczhong84
reviewed
Jun 22, 2023
Comment on lines
70
to
85
| "/comment/<int:comment_id>/text/", | ||
| methods=["PUT"], | ||
| ) | ||
| def edit_comment(comment_id: int, **fields): | ||
| def edit_comment_text(comment_id: int, **fields): | ||
| assert_can_edit_and_delete(comment_id=comment_id) | ||
| return logic.edit_comment(comment_id=comment_id, **fields) | ||
|
|
||
|
|
||
| @register( | ||
| "/comment/<int:comment_id>/", | ||
| methods=["DELETE"], | ||
| "/comment/<int:comment_id>/archive/", | ||
| methods=["PUT"], | ||
| ) | ||
| def remove_comment(comment_id: int): | ||
| def archive_comment(comment_id: int, **fields): | ||
| assert_can_edit_and_delete(comment_id=comment_id) | ||
| return logic.remove_comment(comment_id=comment_id) | ||
| logic.edit_comment(comment_id=comment_id, **fields) | ||
| return |
There was a problem hiding this comment.
the comment update & soft delete in CommentResource are using the previous edit_comment endpoint, these two are not used.
There was a problem hiding this comment.
I am a little bit confused, why can't we use the same methods before, but change remove comment to soft delete?
czgu
reviewed
Jun 23, 2023
Comment on lines
70
to
85
| "/comment/<int:comment_id>/text/", | ||
| methods=["PUT"], | ||
| ) | ||
| def edit_comment(comment_id: int, **fields): | ||
| def edit_comment_text(comment_id: int, **fields): | ||
| assert_can_edit_and_delete(comment_id=comment_id) | ||
| return logic.edit_comment(comment_id=comment_id, **fields) | ||
|
|
||
|
|
||
| @register( | ||
| "/comment/<int:comment_id>/", | ||
| methods=["DELETE"], | ||
| "/comment/<int:comment_id>/archive/", | ||
| methods=["PUT"], | ||
| ) | ||
| def remove_comment(comment_id: int): | ||
| def archive_comment(comment_id: int, **fields): | ||
| assert_can_edit_and_delete(comment_id=comment_id) | ||
| return logic.remove_comment(comment_id=comment_id) | ||
| logic.edit_comment(comment_id=comment_id, **fields) | ||
| return |
There was a problem hiding this comment.
I am a little bit confused, why can't we use the same methods before, but change remove comment to soft delete?
czgu
reviewed
Jun 23, 2023
| archived: true, | ||
| }; | ||
| draft.commentsById[commentId].archived = true; | ||
| draft.commentsById[commentId].text = |
There was a problem hiding this comment.
nit: this line doesn't matter, I dont think we need to remove the text in user's redux yet
czgu
approved these changes
Jun 23, 2023
meowcodes
added a commit
to meowcodes/querybook
that referenced
this pull request
Jun 23, 2023
* ui: fix richtext not clearing * fix popover position issue * archive * clean * clean * add table * update * update * update * update * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable archive comment + add archived comment ui
add clearing to draftjs editor (known issue by draftjs)
tried to make reactions unique in db but db will say some emojis are the same
using formik bc react doesnt like state change along with forwardref?
add commenting for tables
Screen.Recording.2023-06-21.at.4.58.27.PM.mov