Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Catalyst #272

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Support Catalyst #272

merged 1 commit into from
Jul 28, 2020

Conversation

cgmaier
Copy link
Contributor

@cgmaier cgmaier commented Jul 28, 2020

  • just checks a box : )

@jparise
Copy link
Collaborator

jparise commented Jul 28, 2020

@cgmaier Thanks! Is there anything we should add to our integration tests to verify Catalyst support?

@cgmaier
Copy link
Contributor Author

cgmaier commented Jul 28, 2020

@cgmaier Thanks! Is there anything we should add to our integration tests to verify Catalyst support?

not that I'm aware of - this should suffice : )

@jparise jparise merged commit df60b0d into pinterest:master Jul 28, 2020
@cgmaier cgmaier deleted the catalyst branch July 28, 2020 20:31
adlerj pushed a commit to adlerj/PINCache that referenced this pull request Aug 4, 2020
@adlerj-hs
Merge commit 'df60b0d9c1903ca4cdb1e928b04ea1203aa28ad2'
d406ba6 
* commit 'df60b0d9c1903ca4cdb1e928b04ea1203aa28ad2':
  Support Catalyst (pinterest#272)
  Fix the grammar in an assertion failure message (pinterest#270)
  Remove the unused CI directory (pinterest#265)
  Fix up analyze for github CI (pinterest#264)
  Check fileURL outside of the locked scope (pinterest#262)
  Optimization `PINMemoryCache` trim to date (pinterest#252)
  Use correct class name in NSAssert() messages (pinterest#263)
  Remove Danger from the project (pinterest#261)
  Link to master branch workflow from the CI badge
  Test that the "remove object" blocks are called (pinterest#258)
  Fix GitHub Actions CI badge
  Switch to GitHub Actions for CI (pinterest#259)
  Discrepancy between Header Comment and Implementation (pinterest#257)

# Conflicts:
#	Makefile
#	PINCache.xcodeproj/project.pbxproj
#	Tests/PINCacheTests.m
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jparise jparise jparise approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgmaier @jparise