Switch to GitHub Actions for CI #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can we update tests to iOS 13.1 as well? (it means we need to regenerate all snapshots) |
Yes, I'll introduce a multi-version testing matrix now that I've proved it essentially works. |
|
🚫 CI failed with log |
|
🚫 CI failed with log |
|
🚫 CI failed with log |
Closed
|
🚫 CI failed with log |
|
🚫 CI failed with log |
|
🚫 CI failed with log |
|
🚫 CI failed with log |
|
🚫 CI failed with log |
|
🚫 CI failed with log |
jparise
force-pushed
the
github-actions
branch
from
5e9e87f to
cc37b1d
Compare
|
🚫 CI failed with log |
|
Does github have little build status thingies? If so it would be good to update the README. |
garrettmoon
approved these changes
Feb 28, 2020
jparise
force-pushed
the
github-actions
branch
2 times, most recently
from
ef27670 to
bfc33c9
Compare
|
🚫 CI failed with log |
jparise
force-pushed
the
github-actions
branch
from
bfc33c9 to
aa4b823
Compare
This also bumps our testing target platform to iPhone 8 (from iPhone 7) because that's the minimum version available in GitHub's environment.
jparise
force-pushed
the
github-actions
branch
from
aa4b823 to
a85da50
Compare
|
🚫 CI failed with log |
|
🚫 CI failed with log |
adlerj
pushed a commit
to adlerj/PINCache
that referenced
this pull request
Aug 4, 2020
* commit 'df60b0d9c1903ca4cdb1e928b04ea1203aa28ad2': Support Catalyst (pinterest#272) Fix the grammar in an assertion failure message (pinterest#270) Remove the unused CI directory (pinterest#265) Fix up analyze for github CI (pinterest#264) Check fileURL outside of the locked scope (pinterest#262) Optimization `PINMemoryCache` trim to date (pinterest#252) Use correct class name in NSAssert() messages (pinterest#263) Remove Danger from the project (pinterest#261) Link to master branch workflow from the CI badge Test that the "remove object" blocks are called (pinterest#258) Fix GitHub Actions CI badge Switch to GitHub Actions for CI (pinterest#259) Discrepancy between Header Comment and Implementation (pinterest#257) # Conflicts: # Makefile # PINCache.xcodeproj/project.pbxproj # Tests/PINCacheTests.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also bumps our testing target platform to iPhone 8 (from iPhone 7)
because that's the minimum version available in GitHub's environment.