Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discrepancy between Header Comment and Implementation #trivial #257

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Discrepancy between Header Comment and Implementation #trivial #257

merged 1 commit into from
Feb 3, 2020

Conversation

jlaws
Copy link
Contributor

@jlaws jlaws commented Feb 3, 2020

Fixes #256 - Discrepancy between Header Comment and Implementation

@jlaws
Discrepancy between Header Comment and Implementation
ef074c7 
Fixes #256 - Discrepancy between Header Comment and Implementation
@jlaws jlaws requested review from garrettmoon and jparise February 3, 2020 14:44
@ghost
Copy link

ghost commented Feb 3, 2020

1 Warning
⚠️ Any source code changes should have an entry in CHANGELOG.md or have #trivial in their title.

Generated by 🚫 Danger

@ghost
Copy link

ghost commented Feb 3, 2020

🚫 CI failed with log

@jlaws jlaws changed the title Discrepancy between Header Comment and Implementation Discrepancy between Header Comment and Implementation #trivial Feb 3, 2020
garrettmoon
garrettmoon approved these changes Feb 3, 2020
View reviewed changes
Copy link
Collaborator

@garrettmoon garrettmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this up!

@garrettmoon garrettmoon merged commit 6ca6131 into pinterest:master Feb 3, 2020
@jlaws jlaws deleted the patch-1 branch February 3, 2020 21:46
adlerj pushed a commit to adlerj/PINCache that referenced this pull request Aug 4, 2020
@adlerj-hs
Merge commit 'df60b0d9c1903ca4cdb1e928b04ea1203aa28ad2'
d406ba6 
* commit 'df60b0d9c1903ca4cdb1e928b04ea1203aa28ad2':
  Support Catalyst (pinterest#272)
  Fix the grammar in an assertion failure message (pinterest#270)
  Remove the unused CI directory (pinterest#265)
  Fix up analyze for github CI (pinterest#264)
  Check fileURL outside of the locked scope (pinterest#262)
  Optimization `PINMemoryCache` trim to date (pinterest#252)
  Use correct class name in NSAssert() messages (pinterest#263)
  Remove Danger from the project (pinterest#261)
  Link to master branch workflow from the CI badge
  Test that the "remove object" blocks are called (pinterest#258)
  Fix GitHub Actions CI badge
  Switch to GitHub Actions for CI (pinterest#259)
  Discrepancy between Header Comment and Implementation (pinterest#257)

# Conflicts:
#	Makefile
#	PINCache.xcodeproj/project.pbxproj
#	Tests/PINCacheTests.m
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettmoon garrettmoon garrettmoon approved these changes

@jparise jparise Awaiting requested review from jparise

Assignees

@garrettmoon garrettmoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discrepancy between Header Comment and Implementation
2 participants
@jlaws @garrettmoon