Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PINCache doesn't build in Xcode 12 Beta 4 #275

Closed
mycroftcanner opened this issue Aug 7, 2020 · 22 comments
Closed

PINCache doesn't build in Xcode 12 Beta 4 #275

mycroftcanner opened this issue Aug 7, 2020 · 22 comments

Comments

@mycroftcanner
Copy link

It generates a lot of semantic issues:

Incompatible block pointer types sending 'PINMemoryCacheObjectBlock _Nullable __strong' (aka 'void (^__strong)(PINMemoryCache * _Nonnull __strong, NSString * _Nonnull __strong, id _Nullable __strong)') to parameter of type 'PINCacheObjectBlock _Nonnull' (aka 'void (^)(id _Nonnull __strong, NSString * _Nonnull __strong, id _Nullable __strong)')

@ghost
Copy link

ghost commented Aug 7, 2020

This

@mycroftcanner
Copy link
Author

It builds now after this commit but tests fail.

PINMemoryCache is also broken

@garrettmoon
Copy link
Collaborator

@mycroftcanner Tests succeed for me locally, can you explain which tests fail and what you mean by PINMemoryCache is broken?

@arangato
Copy link
Contributor

I had a bunch of compilation errors in tests as well. All looking like the one @mycroftcanner initially reported. I've fixed it in this PR.

@garrettmoon
Copy link
Collaborator

@mycroftcanner I just merged @arangato 's PR (thank you!), does this address what you were hitting?

@AnatolYarmalovich
Copy link

The same issues also available on Xcode Version 12.0 beta 5

@mycroftcanner
Copy link
Author

mycroftcanner commented Aug 27, 2020

@garrettmoon CocoaPods still look for old version and you specify the master branch then PINRemoteImage is out of sync and Texture won't build too.

The following will fail:

  pod 'PINCache', :git => 'https://github.com/pinterest/PINCache', :branch => 'master'
  pod 'PINRemoteImage', :git => 'https://github.com/pinterest/PINRemoteImage', :branch => 'master'

Texture (from https://github.com/TextureGroup/Texture, branch master) was resolved to 3.0.0, which depends > on
Texture/PINRemoteImage (= 3.0.0) was resolved to 3.0.0, which depends on
PINRemoteImage/PINCache was resolved to 3.0.0, which depends on
PINCache (= 3.0.1-beta.8)

There was a simple workaround earlier but not I am super confused.

@bluemachine
Copy link

Issue still persists in Xcode 12 beta 5 with following pods
PINCache (3.0.1-beta.8)
PINOperation (1.1.2)
PINRemoteImage (3.0.0)

Screenshot 2020-08-28 at 23 49 25

@bluemachine
Copy link

Upgraded to Xcode 12 beta 6 and getting just this 1 issue. Hoping you could fix it soon.

Screenshot 2020-08-29 at 16 25 24

@ehsan-ff
Copy link

ehsan-ff commented Sep 4, 2020

Upgraded to Xcode 12 beta 6 and getting just this 1 issue. Hoping you could fix it soon.

Screenshot 2020-08-29 at 16 25 24

Facing the same issue on Xcode 12 beta 6.

@hexadecimal-REBOOT
Copy link

Has anyone been successful with getting it to build. I'm getting the same error message Incompatible block pointer types.

@SAGESSE-CN
Copy link
Contributor

SAGESSE-CN commented Sep 8, 2020

a temporary solution add the flags into bulid config CFLAGS to disable check

-Xclang -fcompatibility-qualified-id-block-type-checking

SAGESSE-CN added a commit to SAGESSE-CN/PINCache that referenced this issue Sep 8, 2020
@garrettmoon
Copy link
Collaborator

This has been fixed in PINCache 3.0.1. We'll put out a new PINRemoteImage release which includes this soon.

@bluemachine
Copy link

When we install the pod PINRemoteImage - it installs with following pods

Installing PINCache (3.0.1-beta.8)
Installing PINOperation (1.1.2)
Installing PINRemoteImage (3.0.0)

To update as suggested - when we install PINCache it updates to latest version but installs an older version of PINRemoteImage and followings pods.

Installing FLAnimatedImage (1.0.12)
Installing PINCache 3.0.1 (was 3.0.1-beta.8)
Installing PINOperation 1.2 (was 1.1.2)
Installing PINRemoteImage 2.1.4 (was 3.0.0)

This gives 4 build errors - screenshots below
Screenshot 2020-09-08 at 20 50 41
Screenshot 2020-09-08 at 20 50 52
Screenshot 2020-09-08 at 20 51 00
Screenshot 2020-09-08 at 20 51 10

Hope this helps in recreating the issue.

@alisamaiee
Copy link

alisamaiee commented Sep 15, 2020

I have fixed it doing these steps:

1- Find PINCache+PINRemoteImageCaching.m file in your project and replace it with this file:
https://github.com/pinterest/PINRemoteImage/blob/master/Source/Classes/PINCache/PINCache%2BPINRemoteImageCaching.m

2- Apply changes of this commit to your project files (or you can simply replace the files which had change during this commit):
10b3c3c

Done!

@Rexrohan
Copy link

a temporary solution add the flags into bulid config CFLAGS to disable check

-Xclang -fcompatibility-qualified-id-block-type-checking

where to add the flag, I have added in build settings flags still error shows.

@Rexrohan
Copy link

I have fixed it doing these steps:

1- Find PINCache+PINRemoteImageCaching.m file in your project and replace it with this file:
https://github.com/pinterest/PINRemoteImage/blob/master/Source/Classes/PINCache/PINCache%2BPINRemoteImageCaching.m

2- Apply changes of this commit to your project files (or you can simply replace the files which had change during this commit):
10b3c3c

Done!

this one also not working for me

@SAYEDALISINA93
Copy link

Still have this issue with the Xcode 12 final version.

Should I change my Xcode back to 11 or there is a solution to solve it?

@VictorZhang2014
Copy link

image
image

It's not working on Xcode 12.0, as you all mentioned above.

@SAGESSE-CN
Copy link
Contributor

SAGESSE-CN commented Oct 22, 2020

It's not working on Xcode 12.0, as you all mentioned above.

You must use PINCache version 3.0.3 or above.

@timeview
Copy link

timeview commented May 6, 2021

I did try PINCache 3.0.3 but still get same errors - Any updates on this issue ?

@bolee
Copy link

bolee commented Sep 8, 2021

upgrade the latest version 3.0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests