Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PINCacheTests compiling in Xcode 12.0b4 #276

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Fix PINCacheTests compiling in Xcode 12.0b4 #276

merged 1 commit into from
Aug 12, 2020

Conversation

arangato
Copy link
Contributor

Fixed type checking for block parameters in tests using id with
protocols. Same as commit 10b3c3c did.

@arangato
Fix PINCacheTests compiling in Xcode 12.0b4
38f0037 
Fixed type checking for block parameters in tests using id with
protocols. Same as commit 10b3c3c did.
@arangato arangato mentioned this pull request Aug 12, 2020
Closed
garrettmoon
garrettmoon approved these changes Aug 12, 2020
View reviewed changes
Copy link
Collaborator

@garrettmoon garrettmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this up!

@garrettmoon garrettmoon merged commit 83ed1a0 into pinterest:master Aug 12, 2020
@arangato arangato deleted the arangato/xcode12-test-fix branch August 13, 2020 06:13
@SAGESSE-CN SAGESSE-CN mentioned this pull request Sep 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettmoon garrettmoon garrettmoon approved these changes

Assignees

@garrettmoon garrettmoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arangato @garrettmoon