Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Texture won't compile with Xcode 12 beta 4 #1894

Closed
mycroftcanner opened this issue Aug 7, 2020 · 12 comments
Closed

Texture won't compile with Xcode 12 beta 4 #1894

mycroftcanner opened this issue Aug 7, 2020 · 12 comments

Comments

@mycroftcanner
Copy link

Texture won't compile with Xcode 12 beta 4 because of an issue in PINCache and PINRemoteIMage

@k1ngcyk
Copy link

k1ngcyk commented Aug 11, 2020

same issue here

@rahulvyas
Copy link

Same with me

@noremac
Copy link

noremac commented Aug 11, 2020

There's an issue in the PINRemoteImage repo, and a PR too. pinterest/PINRemoteImage#559

@zboralski
Copy link

Temporary Workaround

ENV['COCOAPODS_DISABLE_STATS'] = "true"
use_frameworks!

target 'XX' do
    platform :ios, '13.6'
    pod 'Texture', :git => 'https://github.com/TextureGroup/Texture', :branch => 'master'
    pod 'PINRemoteImage', :git => 'https://github.com/zacwest/PINRemoteImage', :branch => 'fix-xcode-12.0b4'
    pod 'PINCache', :git => 'https://github.com/pinterest/PINCache', :branch => 'master'
end

gemmakbarlow added a commit to gemmakbarlow/Texture that referenced this issue Aug 24, 2020
@jabbarwockeez
Copy link

jabbarwockeez commented Aug 25, 2020

@zboralski

Temporary Workaround

ENV['COCOAPODS_DISABLE_STATS'] = "true"
use_frameworks!

target 'XX' do
    platform :ios, '13.6'
    pod 'Texture', :git => 'https://github.com/TextureGroup/Texture', :branch => 'master'
    pod 'PINRemoteImage', :git => 'https://github.com/zacwest/PINRemoteImage', :branch => 'fix-xcode-12.0b4'
    pod 'PINCache', :git => 'https://github.com/pinterest/PINCache', :branch => 'master'
end

I was failed when i tried your solution.

  In Podfile:
    PINCache (from `https://github.com/pinterest/PINCache`, branch `master`)
    PINRemoteImage (from `https://github.com/zacwest/PINRemoteImage`, branch `fix-xcode-12.0b4`) was resolved to 3.0.0, which depends on
    PINRemoteImage/PINCache (= 3.0.0) was resolved to 3.0.0, which depends on
        PINCache (= 3.0.1-beta.8)

@SleepiestAdam
Copy link

Experiencing the same issue as highlighted by @jabbarwockeez.

@faizpathan
Copy link

@zboralski

Temporary Workaround

ENV['COCOAPODS_DISABLE_STATS'] = "true"
use_frameworks!

target 'XX' do
    platform :ios, '13.6'
    pod 'Texture', :git => 'https://github.com/TextureGroup/Texture', :branch => 'master'
    pod 'PINRemoteImage', :git => 'https://github.com/zacwest/PINRemoteImage', :branch => 'fix-xcode-12.0b4'
    pod 'PINCache', :git => 'https://github.com/pinterest/PINCache', :branch => 'master'
end

I was failed when i tried your solution.

  In Podfile:
    PINCache (from `https://github.com/pinterest/PINCache`, branch `master`)
    PINRemoteImage (from `https://github.com/zacwest/PINRemoteImage`, branch `fix-xcode-12.0b4`) was resolved to 3.0.0, which depends on
    PINRemoteImage/PINCache (= 3.0.0) was resolved to 3.0.0, which depends on
        PINCache (= 3.0.1-beta.8)

do this
pod 'Texture', '3.0.0'
pod 'PINRemoteImage', :git => 'https://github.com/pinterest/PINRemoteImage', :branch => 'master'

this works for me

@rogerluan
Copy link
Contributor

There's an issue in the PINRemoteImage repo, and a PR too. pinterest/PINRemoteImage#559

This one has been fixed already, but OP's issue is still a problem for us 😬

@mycroftcanner
Copy link
Author

Finally works using Texture, PINRemoteImage, PinCache master branches. Thanks to all involved <3

Maybe we should keep this issue open until the release version works correctly and according to the README.md?

@rogerluan
Copy link
Contributor

rogerluan commented Sep 6, 2020

Finally works using Texture, PINRemoteImage, PinCache master branches. Thanks to all involved <3

Maybe we should keep this issue open until the release version works correctly and according to the README.md?

How does your Podfile look like, to make it work? Did you have to specify tag, branch or version for Texture, PINRemoteImage, or PinCache?

Thanks in advance!

@lazarevzubov
Copy link

lazarevzubov commented Sep 18, 2020

Builds successfully in Xcode 12 using the latest Texture (pod 'Texture') and without specifying its components versions/branches (so, currently it's PINCache 3.0.1, PINOperation 1.2, PINRemoteImage 3.0.1 and Texture 3.0.0 by default.)

@MeGaPk
Copy link

MeGaPk commented Sep 21, 2020

for hotfix pincache with version 2.8.1, just use it on cocoapod file:

          if target.name == "PINCache" or target.name == "PINRemoteImage"
                puts "Updating #{target.name} OTHER_CFLAGS"
                target.build_configurations.each do |config|
                    config.build_settings['OTHER_CFLAGS'] = '-Xclang -fcompatibility-qualified-id-block-type-checking'
                end
            end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests