Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#9748] skip java 17 it-test #9749

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

donghun-cho
Copy link
Contributor

skiped tests because of no java 17 installation should not create error log

@donghun-cho donghun-cho self-assigned this Mar 3, 2023
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #9749 (e0291c5) into master (36c5693) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##             master    #9749   +/-   ##
=========================================
  Coverage     38.80%   38.81%           
- Complexity    11915    11921    +6     
=========================================
  Files          3514     3515    +1     
  Lines         94079    94089   +10     
  Branches      10529    10529           
=========================================
+ Hits          36507    36518   +11     
+ Misses        54400    54399    -1     
  Partials       3172     3172           
Impacted Files Coverage Δ
...t/test/plugin/AbstractPinpointPluginTestSuite.java 0.00% <0.00%> (ø)
...n/PinpointPluginTestAssumptionViolationRunner.java 0.00% <0.00%> (ø)
...nitor/DefaultDataSourceMonitorRegistryService.java 72.41% <0.00%> (-10.35%) ⬇️
...rc/main/java/com/navercorp/pinpoint/test/Item.java 72.22% <0.00%> (-3.71%) ⬇️
...orp/pinpoint/rpc/server/DefaultPinpointServer.java 81.06% <0.00%> (-0.83%) ⬇️
...ollector/cluster/zookeeper/ZookeeperJobWorker.java 79.67% <0.00%> (+1.60%) ⬆️
...m/navercorp/pinpoint/rpc/client/ConnectFuture.java 79.16% <0.00%> (+8.33%) ⬆️
...rp/pinpoint/rpc/packet/ControlHandshakePacket.java 68.96% <0.00%> (+24.13%) ⬆️
...inpoint/profiler/logging/Log4j2ContextFactory.java 100.00% <0.00%> (+100.00%) ⬆️
...rofiler/logging/EmptyShutdownCallbackRegistry.java 100.00% <0.00%> (+100.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@donghun-cho donghun-cho marked this pull request as draft March 3, 2023 09:34
@donghun-cho donghun-cho force-pushed the test_java17 branch 3 times, most recently from 83e1b7b to 2b718a7 Compare March 9, 2023 02:45
@donghun-cho donghun-cho changed the title [#9748] change log level [#9748] skip java 17 it-test Mar 9, 2023
@donghun-cho donghun-cho marked this pull request as ready for review March 9, 2023 09:00
@donghun-cho donghun-cho linked an issue Mar 9, 2023 that may be closed by this pull request
@donghun-cho donghun-cho added this to the 2.5.1 milestone Mar 9, 2023
@donghun-cho donghun-cho merged commit 362515a into pinpoint-apm:master Mar 9, 2023
@donghun-cho donghun-cho deleted the test_java17 branch March 10, 2023 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failing to find java 17 should not cause error
1 participant