Skip to content

Commit 83e1b7b

Browse files
committed
[#9748] skip java 17 test
1 parent 4dbf95d commit 83e1b7b

File tree

2 files changed

+27
-1
lines changed

2 files changed

+27
-1
lines changed

test/src/main/java/com/navercorp/pinpoint/test/plugin/AbstractPinpointPluginTestSuite.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -364,10 +364,11 @@ protected List<Runner> getChildren() {
364364
for (int ver : jvmVersions) {
365365
String javaExe = getJavaExecutable(ver);
366366

367-
// TODO for now, java 8 is not mandatory to build pinpoint.
367+
// TODO for now, java 17 is not mandatory to build pinpoint.
368368
// so failing to find java installation should not cause build failure.
369369
if (javaExe == null) {
370370
logger.error("Cannot find Java version {}. Skip test with Java {}", ver, ver);
371+
runners.add(new PinpointPluginTestAssumptionViolationRunner(getTestClass().getName() , "Cannot find Java version"));
371372
continue;
372373
}
373374

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
package com.navercorp.pinpoint.test.plugin;
2+
3+
import org.junit.runner.Description;
4+
import org.junit.runner.Runner;
5+
import org.junit.runner.notification.Failure;
6+
import org.junit.runner.notification.RunNotifier;
7+
8+
public class PinpointPluginTestAssumptionViolationRunner extends Runner {
9+
private final Description description;
10+
private final String message;
11+
12+
public PinpointPluginTestAssumptionViolationRunner(String testClassName, String message) {
13+
this.description = Description.createTestDescription(testClassName, "assumption violation");
14+
this.message = message;
15+
}
16+
17+
@Override
18+
public Description getDescription() {
19+
return description;
20+
}
21+
22+
public void run(RunNotifier notifier) {
23+
notifier.fireTestAssumptionFailed(new Failure(description, new PinpointPluginTestException(description.getClassName(), message, null)));
24+
}
25+
}

0 commit comments

Comments
 (0)