Skip to content

Commit 2b718a7

Browse files
committed
[#9748] skip java 17 test
1 parent 36c5693 commit 2b718a7

File tree

2 files changed

+31
-1
lines changed

2 files changed

+31
-1
lines changed

test/src/main/java/com/navercorp/pinpoint/test/plugin/AbstractPinpointPluginTestSuite.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -364,10 +364,11 @@ protected List<Runner> getChildren() {
364364
for (int ver : jvmVersions) {
365365
String javaExe = getJavaExecutable(ver);
366366

367-
// TODO for now, java 8 is not mandatory to build pinpoint.
367+
// TODO for now, java 17 is not mandatory to build pinpoint.
368368
// so failing to find java installation should not cause build failure.
369369
if (javaExe == null) {
370370
logger.error("Cannot find Java version {}. Skip test with Java {}", ver, ver);
371+
runners.add(new PinpointPluginTestAssumptionViolationRunner(getTestClass().getName(), "assumptionFailed", "Cannot find Java version " + ver));
371372
continue;
372373
}
373374

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
package com.navercorp.pinpoint.test.plugin;
2+
3+
import org.junit.runner.Description;
4+
import org.junit.runner.Runner;
5+
import org.junit.runner.notification.Failure;
6+
import org.junit.runner.notification.RunNotifier;
7+
8+
import java.util.Objects;
9+
10+
public class PinpointPluginTestAssumptionViolationRunner extends Runner {
11+
private final Description description;
12+
private final String message;
13+
14+
public PinpointPluginTestAssumptionViolationRunner(String className, String name, String message) {
15+
Objects.requireNonNull(className, "className");
16+
Objects.requireNonNull(name, "name");
17+
this.description = Description.createTestDescription(className, name);
18+
this.message = Objects.requireNonNull(message, "message");
19+
}
20+
21+
@Override
22+
public Description getDescription() {
23+
return description;
24+
}
25+
26+
public void run(RunNotifier notifier) {
27+
notifier.fireTestAssumptionFailed(new Failure(description, new PinpointPluginTestException(description.getClassName(), message, null)));
28+
}
29+
}

0 commit comments

Comments
 (0)