chore(ci): narrow the UI consistency check-run agent - #9297
Conversation
The Macroscope UI consistency agent had grown from a styling guard into a general review: it accumulated PR-specific rules (contrast tokens, environment routing, MenuPopup width defaulting, scroll-fade geometry) and instructed the agent to inspect emitted CSS, trace selector consumers, and verify runtime behavior on every run. That made each run expensive. Cut the prompt to the three things it was meant to guard: use the ui/ primitives, keep styling as Tailwind on the owning component instead of global CSS, and keep components composable, using the composer banner stack as the reference shape. Drop git_tools and github_api_read_only, narrow include to .tsx/.css, lower effort to medium, and cap spend per run. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This is a CI-only change with no direct product runtime impact, but it materially narrows automated review coverage and modifies a Not approved because:
Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more. |
## What's Changed * feat(desktop): browser profiles for the preview browser by @juliusmarminge in pingdotgg/t3code#7254 * refactor(shared): move the node:sqlite Effect SQL client into shared by @juliusmarminge in pingdotgg/t3code#7272 * feat(web): add opt-in panel animations by @maria-rcks in pingdotgg/t3code#8830 * feat(projects): automatically pull clean default branches by @maria-rcks in pingdotgg/t3code#9277 * fix(web): show pull request state icons in tabs by @flamboh in pingdotgg/t3code#9112 * feat(providers): add context compaction across harnesses by @maria-rcks in pingdotgg/t3code#8808 * feat(web): add proactive panels by @maria-rcks in pingdotgg/t3code#9276 * fix(web): unify control sizing across settings pages by @juliusmarminge in pingdotgg/t3code#9281 * fix(web): offer browser profiles from the empty-panel launcher by @juliusmarminge in pingdotgg/t3code#9279 * Revert "feat(providers): add context compaction across harnesses" by @maria-rcks in pingdotgg/t3code#9284 * fix(web): show scroll-to-end as soon as the last message slips under the composer by @juliusmarminge in pingdotgg/t3code#9280 * fix(cursor): honor auto and full access modes by @maria-rcks in pingdotgg/t3code#9283 * fix(desktop): detect installed Spectre libs for Windows builds by @juliusmarminge in pingdotgg/t3code#9285 * fix(pull-requests): missing features & better behaviour by @maria-rcks in pingdotgg/t3code#9188 * fix(providers): discover workspace skills everywhere by @maria-rcks in pingdotgg/t3code#9180 * fix(server): preserve automatic settlement timestamps by @eimexdev in pingdotgg/t3code#9254 * fix(opencode): show Reasoning selector for OpenCode models by @maria-rcks in pingdotgg/t3code#9287 * feat(web): preview document attachments in the file viewer by @juliusmarminge in pingdotgg/t3code#9292 * chore(ci): narrow the UI consistency check-run agent by @juliusmarminge in pingdotgg/t3code#9297 **Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260902.1261...v0.0.39-nightly.20260903.1262 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1262
The Macroscope UI Consistency check-run agent had drifted from a styling guard into a general review and was costing a lot per run. Since #6381 it picked up PR-specific rules from #7906 (contrast tokens,
filteron the root) and #7140 (environment routing in shared renderers, which is not a styling concern at all), plus standing instructions to inspect emitted production CSS, trace selector consumers across the codebase, compare cascade layers, and verify runtime scroll behavior on every run.This cuts the prompt from 11.6 KB to about 4 KB and scopes it back to what it was meant to guard:
apps/web/src/components/uiprimitives instead of rebuilding controls.ComposerBanner.tsx,ComposerBannerStack.tsx, and its consumers) named as the reference for how slot components should be shaped.The prompt now opens by telling the agent to stay at diff level (no builds, no emitted-CSS inspection, no consumer tracing, no screenshot requests) and that a violation not obvious from the diff is not a finding.
Frontmatter changes: drop
git_toolsandgithub_api_read_only, narrowincludeto.tsx/.cssand exclude tests, lowereffortfromhightomedium, and addmaxBudgetPerRun: 10. Still runs onclaude-opus-5withconclusion: failure.The environment-routing rules removed here were a real correctness concern from #7140; if we still want them guarded they belong in their own agent.
Claude Fable 5 via Claude Code
🤖 Generated with Claude Code
Note
Low Risk
Config-only change to a CI agent prompt; the tradeoff is less automated coverage for environment routing and deep CSS/theme checks unless another agent picks them up.
Overview
Narrows the Macroscope UI Consistency agent from a broad web review back to a diff-only styling guard for
apps/web, with a much shorter prompt (~11.6 KB → ~4 KB) and lower run cost.The agent now answers three questions only: use
components/uiprimitives instead of raw controls, keep styling as Tailwind on the owning component (not new global CSS or static inline styles), and follow the ComposerBanner slot pattern for composable UI. It explicitly forbids builds, emitted-CSS inspection, consumer tracing, and screenshot requests; violations must be obvious from the diff.Frontmatter:
effortmedium,maxBudgetPerRun: 10,includelimited to**/*.tsxand**/*.csswith test files excluded, andgit_tools/github_api_read_onlyremoved (stillbrowse_code+modify_pr).showToolCallsdropped.Removed from the prompt: contrast/token rules, root
filterguidance, environment routing in shared renderers, scroll/virtualized-list checks, visual-evidence requirements, and deep CSS cascade/selector auditing—those are no longer part of this check.Reviewed by Cursor Bugbot for commit 04953ef. Bugbot is set up for automated code reviews on this repo. Configure here.