Skip to content

chore(ci): narrow the UI consistency check-run agent - #9297

Merged
juliusmarminge merged 1 commit into
mainfrom
t3code/simplify-ui-consistency-check
Sep 3, 2026
Merged

chore(ci): narrow the UI consistency check-run agent#9297
juliusmarminge merged 1 commit into
mainfrom
t3code/simplify-ui-consistency-check

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Sep 3, 2026

Copy link
Copy Markdown
Member

The Macroscope UI Consistency check-run agent had drifted from a styling guard into a general review and was costing a lot per run. Since #6381 it picked up PR-specific rules from #7906 (contrast tokens, filter on the root) and #7140 (environment routing in shared renderers, which is not a styling concern at all), plus standing instructions to inspect emitted production CSS, trace selector consumers across the codebase, compare cascade layers, and verify runtime scroll behavior on every run.

This cuts the prompt from 11.6 KB to about 4 KB and scopes it back to what it was meant to guard:

  1. Use the apps/web/src/components/ui primitives instead of rebuilding controls.
  2. Keep styling as Tailwind classes on the owning component instead of adding global CSS or static inline styles.
  3. Keep components composable, with the composer banner stack (ComposerBanner.tsx, ComposerBannerStack.tsx, and its consumers) named as the reference for how slot components should be shaped.

The prompt now opens by telling the agent to stay at diff level (no builds, no emitted-CSS inspection, no consumer tracing, no screenshot requests) and that a violation not obvious from the diff is not a finding.

Frontmatter changes: drop git_tools and github_api_read_only, narrow include to .tsx/.css and exclude tests, lower effort from high to medium, and add maxBudgetPerRun: 10. Still runs on claude-opus-5 with conclusion: failure.

The environment-routing rules removed here were a real correctness concern from #7140; if we still want them guarded they belong in their own agent.

Claude Fable 5 via Claude Code

🤖 Generated with Claude Code


Note

Low Risk
Config-only change to a CI agent prompt; the tradeoff is less automated coverage for environment routing and deep CSS/theme checks unless another agent picks them up.

Overview
Narrows the Macroscope UI Consistency agent from a broad web review back to a diff-only styling guard for apps/web, with a much shorter prompt (~11.6 KB → ~4 KB) and lower run cost.

The agent now answers three questions only: use components/ui primitives instead of raw controls, keep styling as Tailwind on the owning component (not new global CSS or static inline styles), and follow the ComposerBanner slot pattern for composable UI. It explicitly forbids builds, emitted-CSS inspection, consumer tracing, and screenshot requests; violations must be obvious from the diff.

Frontmatter: effort medium, maxBudgetPerRun: 10, include limited to **/*.tsx and **/*.css with test files excluded, and git_tools / github_api_read_only removed (still browse_code + modify_pr). showToolCalls dropped.

Removed from the prompt: contrast/token rules, root filter guidance, environment routing in shared renderers, scroll/virtualized-list checks, visual-evidence requirements, and deep CSS cascade/selector auditing—those are no longer part of this check.

Reviewed by Cursor Bugbot for commit 04953ef. Bugbot is set up for automated code reviews on this repo. Configure here.

The Macroscope UI consistency agent had grown from a styling guard into a
general review: it accumulated PR-specific rules (contrast tokens,
environment routing, MenuPopup width defaulting, scroll-fade geometry)
and instructed the agent to inspect emitted CSS, trace selector consumers,
and verify runtime behavior on every run. That made each run expensive.

Cut the prompt to the three things it was meant to guard: use the ui/
primitives, keep styling as Tailwind on the owning component instead of
global CSS, and keep components composable, using the composer banner
stack as the reference shape. Drop git_tools and github_api_read_only,
narrow include to .tsx/.css, lower effort to medium, and cap spend per run.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Sep 3, 2026
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 13.3 KiB 13.2 KiB −93 B (−0.7%) 15.1 KiB
Codex Thread snapshot wire 6.9 KiB 6.9 KiB 0 B (0.0%) 7.3 KiB
Codex Live turn WebSocket wire 6.4 KiB 6.3 KiB −93 B (−1.4%) 7.8 KiB
Codex Live turn WebSocket decoded 55.6 KiB 55.5 KiB −88 B (−0.2%) 66.4 KiB
Codex Live turn messages 10 8 −2 (−20.0%) 21
Claude Total thread wire 13.3 KiB 13.2 KiB −58 B (−0.4%) 15.1 KiB
Claude Thread snapshot wire 6.9 KiB 6.9 KiB −2 B (−0.0%) 7.3 KiB
Claude Live turn WebSocket wire 6.4 KiB 6.3 KiB −56 B (−0.9%) 7.8 KiB
Claude Live turn WebSocket decoded 56.4 KiB 56.3 KiB −44 B (−0.1%) 66.4 KiB
Claude Live turn messages 9 8 −1 (−11.1%) 21

Baseline: 7751299 · PR result: 04953ef · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

macroscopeapp Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This is a CI-only change with no direct product runtime impact, but it materially narrows automated review coverage and modifies a .macroscope/ configuration file. Human review is required for changes that alter Macroscope’s own review behavior.

Not approved because:

  • Monthly spending limit reached (workspace setting). Approvability relies on correctness review in order to determine eligibility

Review your spending limits in Billing settings. You can add or adjust custom eligibility rules. Learn more.

@juliusmarminge
juliusmarminge merged commit e94603a into main Sep 3, 2026
20 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/simplify-ui-consistency-check branch September 3, 2026 01:09
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* feat(desktop): browser profiles for the preview browser by @juliusmarminge in pingdotgg/t3code#7254
* refactor(shared): move the node:sqlite Effect SQL client into shared by @juliusmarminge in pingdotgg/t3code#7272
* feat(web): add opt-in panel animations by @maria-rcks in pingdotgg/t3code#8830
* feat(projects): automatically pull clean default branches by @maria-rcks in pingdotgg/t3code#9277
* fix(web): show pull request state icons in tabs by @flamboh in pingdotgg/t3code#9112
* feat(providers): add context compaction across harnesses by @maria-rcks in pingdotgg/t3code#8808
* feat(web): add proactive panels by @maria-rcks in pingdotgg/t3code#9276
* fix(web): unify control sizing across settings pages by @juliusmarminge in pingdotgg/t3code#9281
* fix(web): offer browser profiles from the empty-panel launcher by @juliusmarminge in pingdotgg/t3code#9279
* Revert "feat(providers): add context compaction across harnesses" by @maria-rcks in pingdotgg/t3code#9284
* fix(web): show scroll-to-end as soon as the last message slips under the composer by @juliusmarminge in pingdotgg/t3code#9280
* fix(cursor): honor auto and full access modes by @maria-rcks in pingdotgg/t3code#9283
* fix(desktop): detect installed Spectre libs for Windows builds by @juliusmarminge in pingdotgg/t3code#9285
* fix(pull-requests): missing features & better behaviour by @maria-rcks in pingdotgg/t3code#9188
* fix(providers): discover workspace skills everywhere by @maria-rcks in pingdotgg/t3code#9180
* fix(server): preserve automatic settlement timestamps by @eimexdev in pingdotgg/t3code#9254
* fix(opencode): show Reasoning selector for OpenCode models by @maria-rcks in pingdotgg/t3code#9287
* feat(web): preview document attachments in the file viewer by @juliusmarminge in pingdotgg/t3code#9292
* chore(ci): narrow the UI consistency check-run agent by @juliusmarminge in pingdotgg/t3code#9297


**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260902.1261...v0.0.39-nightly.20260903.1262

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1262
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant