fix(web): show pull request state icons in tabs - #9112
Merged
maria-rcks merged 2 commits intoSep 2, 2026
Conversation
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a contained web UI bug fix that replaces unreliable local status propagation with existing cached pull-request detail and list seeds. Runtime impact is limited to state-icon rendering and bounded detail reads, with no schema, product-default, deployment, security, billing, or static-analysis changes. You can add or adjust custom eligibility rules. Learn more. |
github-actions Bot
added a commit
to omarcresp/t3code-flake
that referenced
this pull request
Sep 3, 2026
## What's Changed * feat(desktop): browser profiles for the preview browser by @juliusmarminge in pingdotgg/t3code#7254 * refactor(shared): move the node:sqlite Effect SQL client into shared by @juliusmarminge in pingdotgg/t3code#7272 * feat(web): add opt-in panel animations by @maria-rcks in pingdotgg/t3code#8830 * feat(projects): automatically pull clean default branches by @maria-rcks in pingdotgg/t3code#9277 * fix(web): show pull request state icons in tabs by @flamboh in pingdotgg/t3code#9112 * feat(providers): add context compaction across harnesses by @maria-rcks in pingdotgg/t3code#8808 * feat(web): add proactive panels by @maria-rcks in pingdotgg/t3code#9276 * fix(web): unify control sizing across settings pages by @juliusmarminge in pingdotgg/t3code#9281 * fix(web): offer browser profiles from the empty-panel launcher by @juliusmarminge in pingdotgg/t3code#9279 * Revert "feat(providers): add context compaction across harnesses" by @maria-rcks in pingdotgg/t3code#9284 * fix(web): show scroll-to-end as soon as the last message slips under the composer by @juliusmarminge in pingdotgg/t3code#9280 * fix(cursor): honor auto and full access modes by @maria-rcks in pingdotgg/t3code#9283 * fix(desktop): detect installed Spectre libs for Windows builds by @juliusmarminge in pingdotgg/t3code#9285 * fix(pull-requests): missing features & better behaviour by @maria-rcks in pingdotgg/t3code#9188 * fix(providers): discover workspace skills everywhere by @maria-rcks in pingdotgg/t3code#9180 * fix(server): preserve automatic settlement timestamps by @eimexdev in pingdotgg/t3code#9254 * fix(opencode): show Reasoning selector for OpenCode models by @maria-rcks in pingdotgg/t3code#9287 * feat(web): preview document attachments in the file viewer by @juliusmarminge in pingdotgg/t3code#9292 * chore(ci): narrow the UI consistency check-run agent by @juliusmarminge in pingdotgg/t3code#9297 **Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260902.1261...v0.0.39-nightly.20260903.1262 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1262
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
🤖 GPT-5.6 Sol on behalf of Oliver
Problem
Pull request tabs always used the open PR icon, even after a PR was merged, closed, or marked as a draft. Their state also depended on which detail panel had been opened.
Fix
Each tab now reads the cached PR state and uses the same icon as the PR list. The list page seeds that state so icons are correct on the first paint too.
UI changes
Before
After
Verification
vp test run apps/web/src/components/RightPanelTabs.test.tsx apps/web/src/rightPanelStore.test.ts, 50 tests passedvp run --filter @t3tools/web typecheckgit diff --checkChanges prepared by Fable-5.1 in T3 Code.
Note
[!NOTE]
Resolve pull request tab icons from live environment detail instead of local status map
updatePullRequestTabStatusand the localpullRequestTabStatusesstate map from ChatView.tsx and rightPanelStore.ts; tab status is no longer maintained locally.PullRequestSurfaceIconin RightPanelTabs.tsx, which fetches live PR detail viauseEnvironmentQueryand derives the icon/tone throughresolvePullRequestState, falling back to aPullRequestTabStatusSeed(state/draft only) from list rows.RightPanelTabsnow requires anenvironmentIdprop and acceptspullRequestStatusSeedsinstead ofpullRequestStatuses; callers in ChatView.tsx and _chat.pull-requests.tsx are updated.RightPanelTabsPropsnow requiresenvironmentIdand replacespullRequestStatuseswithpullRequestStatusSeeds; callers not updated will fail to compile.Macroscope summarized 327a9a7.