Skip to content

fix(cursor): honor auto and full access modes - #9283

Merged
maria-rcks merged 2 commits into
pingdotgg:mainfrom
maria-rcks:t3code/fix-cursor-auto-approve
Sep 2, 2026
Merged

fix(cursor): honor auto and full access modes#9283
maria-rcks merged 2 commits into
pingdotgg:mainfrom
maria-rcks:t3code/fix-cursor-auto-approve

Conversation

@maria-rcks

@maria-rcks maria-rcks commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Note

Written by gpt-5.6-sol on behalf of Maria

Cursor's Full access and Auto runtime modes were launched like restrictive modes, leaving approval behavior dependent on reactive permission replies.
Full access now starts Cursor with --force, while Auto starts it with native Smart Auto review through --auto-review; supervised modes stay unchanged.
Verified with 26 targeted tests, server typecheck and lint, plus a real T3 Code Auto/Auto thread against an authenticated Cursor CLI that ran git status --short without an approval prompt and spawned cursor-agent --auto-review acp.
Fixes #6533; built by gpt-5.6-sol in the Codex harness.


Note

Medium Risk
Changes how Cursor CLI is spawned for permission-sensitive modes; incorrect mapping could over-approve or under-approve tool actions at session start.

Overview
Cursor ACP sessions now map the thread runtime mode to cursor-agent startup flags instead of always launching plain acp.

Full access adds --force so approvals are relaxed at process start (not only via reactive permission replies). Auto adds --auto-review; supervised-style modes keep unchanged args. CursorAdapter forwards input.runtimeMode into makeCursorAcpRuntime / buildCursorAcpSpawnInput, with unit and adapter tests asserting the argv log. User docs note that Auto on Cursor uses Smart Auto review.

Reviewed by Cursor Bugbot for commit 84baae0. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix CursorAdapter to honor auto and full-access permission modes

  • Adds cursorAcpPermissionArgs in CursorAcpSupport.ts to map runtime modes to Cursor ACP launch arguments: auto selects Cursor automatic review, full-access selects forced approval, other modes get no extra argument
  • Threads the runtime mode from CursorAdapter.startSession through makeCursorAcpRuntime into buildCursorAcpSpawnInput, which inserts the selected permission args before the ACP subcommand
  • Updates permission-modes.md to list Cursor Smart Auto review under Auto-mode providers

Macroscope summarized 84baae0.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 2, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — The PR changes Cursor's production permission behavior by adding startup flags for Auto and the product-default Full access mode. Because this affects approval and unattended execution semantics on an existing path, human review is warranted despite the focused diff and added tests.

You can add or adjust custom eligibility rules. Learn more.

@maria-rcks maria-rcks changed the title fix(cursor): honor full access at process startup fix(cursor): honor auto and full access modes Sep 2, 2026
@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). and removed size:S 10-29 changed lines (additions + deletions). labels Sep 2, 2026
@maria-rcks
maria-rcks merged commit 994bd73 into pingdotgg:main Sep 2, 2026
25 checks passed
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* feat(desktop): browser profiles for the preview browser by @juliusmarminge in pingdotgg/t3code#7254
* refactor(shared): move the node:sqlite Effect SQL client into shared by @juliusmarminge in pingdotgg/t3code#7272
* feat(web): add opt-in panel animations by @maria-rcks in pingdotgg/t3code#8830
* feat(projects): automatically pull clean default branches by @maria-rcks in pingdotgg/t3code#9277
* fix(web): show pull request state icons in tabs by @flamboh in pingdotgg/t3code#9112
* feat(providers): add context compaction across harnesses by @maria-rcks in pingdotgg/t3code#8808
* feat(web): add proactive panels by @maria-rcks in pingdotgg/t3code#9276
* fix(web): unify control sizing across settings pages by @juliusmarminge in pingdotgg/t3code#9281
* fix(web): offer browser profiles from the empty-panel launcher by @juliusmarminge in pingdotgg/t3code#9279
* Revert "feat(providers): add context compaction across harnesses" by @maria-rcks in pingdotgg/t3code#9284
* fix(web): show scroll-to-end as soon as the last message slips under the composer by @juliusmarminge in pingdotgg/t3code#9280
* fix(cursor): honor auto and full access modes by @maria-rcks in pingdotgg/t3code#9283
* fix(desktop): detect installed Spectre libs for Windows builds by @juliusmarminge in pingdotgg/t3code#9285
* fix(pull-requests): missing features & better behaviour by @maria-rcks in pingdotgg/t3code#9188
* fix(providers): discover workspace skills everywhere by @maria-rcks in pingdotgg/t3code#9180
* fix(server): preserve automatic settlement timestamps by @eimexdev in pingdotgg/t3code#9254
* fix(opencode): show Reasoning selector for OpenCode models by @maria-rcks in pingdotgg/t3code#9287
* feat(web): preview document attachments in the file viewer by @juliusmarminge in pingdotgg/t3code#9292
* chore(ci): narrow the UI consistency check-run agent by @juliusmarminge in pingdotgg/t3code#9297


**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260902.1261...v0.0.39-nightly.20260903.1262

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1262
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Cursor provider still prompts for tool approvals in Full access and Auto runtime modes

1 participant