fix(chat): smooth worktree setup status - #8922
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Warning Your free Security trial is over. An organization admin can activate Security or dismiss this notice. Comment |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
Bugbot Autofix is ON, but a cloud agent failed to start.
Reviewed by Cursor Bugbot for commit 0e6f80e. Configure here.
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — The change improves worktree setup feedback, but it also changes draft promotion timing, shared activity filtering, and timeline rendering/scroll anchoring across web and mobile. Because these interconnected production paths have a broader behavioral surface than a small isolated UI fix, human review is warranted. You can add or adjust custom eligibility rules. Learn more. |
There was a problem hiding this comment.
Reviewed the web UI changes for shared-component/Tailwind ownership and visual behavior. Three findings, one of which is a concrete duplicated-status inconsistency introduced by this patch.
Posted via Macroscope — UI Consistency
## What's Changed * chore(deps): bump Electron to 43.4.1 by @StiensWout in pingdotgg/t3code#8626 * fix(chat): smooth worktree setup status by @juliusmarminge in pingdotgg/t3code#8922 * feat(mobile): add video playback with native iOS controls by @juliusmarminge in pingdotgg/t3code#8919 **Full Changelog**: pingdotgg/t3code@v0.0.38-nightly.20260831.1240...v0.0.38-nightly.20260831.1241 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.38-nightly.20260831.1241
The v2 equivalents of main's #8984 and #8922: a "Working for ..." header anchors the active run, the trailing live tool row survives between actions in past tense instead of vanishing, and a shimmering Thinking row marks reasoning gaps. During workspace preparation the header shows "Setting up worktree..." (driven by the local dispatch flag or the v2 run's preparing status, so remote viewers see it too), the composer footer span is gone, and draft promotion waits until the run starts or startup fails instead of navigating mid-preparation. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
## What's Changed * Add mobile composer attachment menu with video support by @juliusmarminge in pingdotgg/t3code#8843 * fix(web): restore unified activity logs and composer banners by @t3dotgg in pingdotgg/t3code#8734 * fix(web): address composer banner review follow-ups by @juliusmarminge in pingdotgg/t3code#8850 * fix(web): widen sync banners and simplify the working timer by @juliusmarminge in pingdotgg/t3code#8855 * fix(preview): improve browser recording quality by @maria-rcks in pingdotgg/t3code#8839 * fix(web): mark pull request links as external by @juliusmarminge in pingdotgg/t3code#8856 * fix(mobile): replace Callstack glass with Expo glass by @juliusmarminge in pingdotgg/t3code#8862 * fix(server): skip IDE detection in Claude probes by @yashranaway in pingdotgg/t3code#8634 * chore(macroscope): review diagnostic overrides by @t3-code[bot] in pingdotgg/t3code#8917 * fix(contracts): accept CLI event origins by @nateEc in pingdotgg/t3code#8905 * fix(web): hide invalid slash skill completions by @nateEc in pingdotgg/t3code#8904 * fix(mobile): defer draft navigation until submission completes by @juliusmarminge in pingdotgg/t3code#8914 * chore: disable CodeRabbit review status by @juliusmarminge in pingdotgg/t3code#8933 * Delete app.json by @juliusmarminge in pingdotgg/t3code#8934 * fix(web): show scrollbar for wide markdown tables by @UtkarshUsername in pingdotgg/t3code#8868 * fix(mobile): shimmer active tool rows by @juliusmarminge in pingdotgg/t3code#8932 * chore(deps): bump Electron to 43.4.1 by @StiensWout in pingdotgg/t3code#8626 * fix(chat): smooth worktree setup status by @juliusmarminge in pingdotgg/t3code#8922 * feat(mobile): add video playback with native iOS controls by @juliusmarminge in pingdotgg/t3code#8919 * fix(web): prevent chat metadata overlap by @MatthewFeroz in pingdotgg/t3code#8851 * fix(server): preserve usage cache outside walked roots by @Lucenx9 in pingdotgg/t3code#8540 * feat(mobile): add native image and PDF previews by @juliusmarminge in pingdotgg/t3code#8959 * fix(server): allow long thread IDs in HTTP routes by @nateEc in pingdotgg/t3code#8898 * fix(shared): preserve Windows shell PATH priority by @UtkarshUsername in pingdotgg/t3code#8748 * fix(web): make WSL settings searchable by @UtkarshUsername in pingdotgg/t3code#8881 * feat(web): add expand/collapse all control to the files surface by @UtkarshUsername in pingdotgg/t3code#8889 * feat(mobile): upload attachments while composing by @juliusmarminge in pingdotgg/t3code#8978 * fix(chat): keep agent activity visible between actions by @maria-rcks in pingdotgg/t3code#8984 * fix(server): isolate remote web session cookies by @Bil0000 in pingdotgg/t3code#8085 * feat(pull-requests): link GitHub references in markdown by @maria-rcks in pingdotgg/t3code#8812 * perf(server): reduce frequency of full tool call output being loaded into memory from db by @t3dotgg in pingdotgg/t3code#8988 * feat(web): add pull request list filters by @maria-rcks in pingdotgg/t3code#8809 * feat(web): search individual settings by detail by @maria-rcks in pingdotgg/t3code#8831 * feat(client): render viewed images in work logs by @maria-rcks in pingdotgg/t3code#8936 * fix(client): use package import for markdown image helpers by @juliusmarminge in pingdotgg/t3code#9010 * test: remove static presentation snapshots by @t3-code[bot] in pingdotgg/t3code#9008 * perf(server): bound snapshot activity payload memory by @t3dotgg in pingdotgg/t3code#9000 * perf(server): cut idle CPU use and stop provider event leaks by @t3dotgg in pingdotgg/t3code#8187 * perf(server): scan only appended transcript bytes for usage summaries by @StiensWout in pingdotgg/t3code#9024 * perf(server): cut chatty tool-update frames by 90% by @Adamulek123 in pingdotgg/t3code#8368 * fix(server): settle threads server-side by @t3dotgg in pingdotgg/t3code#8600 * fix(clients): dedupe skills in composer menus by @Adamulek123 in pingdotgg/t3code#8043 * fix(server): stop OpenCode child sessions by @t3dotgg in pingdotgg/t3code#9005 * perf(web): defer pull request line stats until visible by @Adamulek123 in pingdotgg/t3code#6471 * perf(server): skip full-message reads while streaming by @t3dotgg in pingdotgg/t3code#9032 * perf(client-runtime): halve server config bootstrap traffic by @Adamulek123 in pingdotgg/t3code#8367 * fix(web): align un-settle banner action by @StiensWout in pingdotgg/t3code#9033 * fix(web): block type-to-focus behind open dialogs by @Lucenx9 in pingdotgg/t3code#8139 * feat(shortcuts): copy active thread reference by @maria-rcks in pingdotgg/t3code#8994 * fix(mobile): keep thread scroll bounds current after animations by @juliusmarminge in pingdotgg/t3code#9013 * fix(server): cache project favicon resolution by @willsheldon in pingdotgg/t3code#9080 * feat(claude): add Claude Fable 5.1 model by @q1 in pingdotgg/t3code#9078 * fix(preview): restore recording and macOS rendering after Electron 43 by @StiensWout in pingdotgg/t3code#9001 * feat(desktop): add configurable quit shortcut confirmation by @juliusmarminge in pingdotgg/t3code#9076 * feat(web): open project settings from thread menus by @SunkenInTime in pingdotgg/t3code#8925 * fix(chat): reuse one row for live activity by @maria-rcks in pingdotgg/t3code#9062 * feat(models): discover Claude models from remote manifest by @juliusmarminge in pingdotgg/t3code#9084 * Revert "fix(chat): reuse one row for live activity" by @maria-rcks in pingdotgg/t3code#9096 * fix(web): sync sidebar PR state from open panel by @t3-code[bot] in pingdotgg/t3code#9092 * fix(web): changing projects no longer creates a draft by @extoci in pingdotgg/t3code#9097 * fix(web): keep theme placeholder text dimmer than entered text by @flamboh in pingdotgg/t3code#9104 * fix(web): keep the selected environment when changing projects by @t3dotgg in pingdotgg/t3code#9102 ## New Contributors * @willsheldon made their first contribution in pingdotgg/t3code#9080 * @q1 made their first contribution in pingdotgg/t3code#9078 **Full Changelog**: pingdotgg/t3code@v0.0.37...v0.0.38 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.38
The v2 equivalents of main's #8984 and #8922: a "Working for ..." header anchors the active run, the trailing live tool row survives between actions in past tense instead of vanishing, and a shimmering Thinking row marks reasoning gaps. During workspace preparation the header shows "Setting up worktree..." (driven by the local dispatch flag or the v2 run's preparing status, so remote viewers see it too), the composer footer span is gone, and draft promotion waits until the run starts or startup fails instead of navigating mid-preparation. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The merge re-exposed several fork seams around upstream's banner dock and working row: - the prompt frame regained upstream's attached-banner glass (backdrop filter, drop shadow, ::after ring) for every banner except Questions; shed it unconditionally since the surface owns the fill and hairline - the Questions drawer kept ComposerBanner.Root's 4px inset on three sides; clear all padding, not only the bottom - the stash tab squeezed the full-width Questions card; the dock stacks and the tab rides above the card's right shoulder instead - "Preparing worktree..." rendered twice: upstream pingdotgg#8922 moved it into the timeline working row, so drop the composer control-row copy - the working-row rain sat baseline-aligned and gapless against the timer text after upstream's row rewrite; centre it with an 8px gap - the shell kept the mode/model row painted under the mobile pending-answer cluster, which upstream hides - BranchToolbar's no-thread branch reuses the liveness strip fallback instead of re-rendering it inline with a dead measure ref - drop the unused PencilRulerIcon import and a redundant guard clause Guards and manifest intents updated to pin each of these. Claude Fable 5.1 via Claude Code. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

What changed
Creating a thread with a new worktree could make the timeline jump and leave a "Received 2 updates" group above the running turn.
Web setup now uses a fixed-height status line: shimmering "Setting up worktree…" changes to "Working for…" when the turn starts. The normal Thinking marker then appears below, until assistant content or live tool activity replaces it. Its space stays reserved during setup so the handoff does not shift the timeline. The draft stays mounted through setup and keeps its timeline position when navigation completes.
Routine setup notices are omitted from the web and mobile work logs. Setup errors stay visible. Mobile shows the pending label in its workspace controls. Both shimmer implementations respect reduced motion.
UI changes
The same completed thread on the base version and this branch:
Successful worktree setup recording: a real checkout, the shimmer-to-timer handoff with Thinking, and the completed response. The fixture briefly pauses checkout so the transition is visible.
Failed worktree setup recording: a Git checkout hook deliberately exits with an error. Setup feedback clears, the error remains, and the original prompt returns to an editable draft with Send available.
Ordinary turn before its first response: a current-checkout turn shows the working timer and Thinking immediately, then the response.
Failed checkout screenshot
Validation
Checklist
Note
Medium Risk
Changes draft promotion timing and timeline row derivation, which affect first-send and worktree flows; behavior is covered by new tests but navigation edge cases are user-visible.
Overview
Improves worktree setup so chat stays visually stable: one fixed-height status line shimmers “Setting up worktree…” (web timeline and mobile new-task workspace controls), then hands off to “Working for…” when the turn starts. The composer footer no longer shows a separate “Preparing worktree…” label.
Draft → thread navigation waits until the server has something meaningful to show: the first turn has
startedAt, or the session ends in error / stopped / interrupted. That keeps the draft mounted through checkout/setup instead of promoting too early.Work logs on web and mobile drop routine
setup-script.requested/setup-script.startednoise via sharedisWorktreeSetupActivity; error-toned setup failures still appear in the feed.The active-turn working row no longer always shows a placeholder “Thinking” line—only when there’s no assistant text and no live tool activity—reducing extra rows at setup-to-turn transitions. Timeline anchoring uses
CHAT_TIMELINE_ANCHOR_OFFSET(24px) so promotion preserves scroll position.Reviewed by Cursor Bugbot for commit 4b10ed5. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Smooth worktree setup status across mobile and web chat UI
setup-script.requestedandsetup-script.startedactivities from derived work logs unless they are error-toned, via newisWorktreeSetupActivityhelper in presentation.tsActivityShimmerOverlayand increases timeline anchor offset from 16 to 24 in timelineScrollAnchoring.tsresolveDraftPromotionNavigationTargetsignature changes from boolean toserverThreadobject; callers in ChatView.logic.ts and _chat.draft.$draftId.tsx are updated but out-of-tree consumers would breakMacroscope summarized 4b10ed5.