fix(web): hide invalid slash skill completions - #8904
Conversation
Do not offer skills from slash completion when the trigger is outside the start of the prompt. Keep built-in and provider slash commands available at later line starts, while preventing a selected skill from being sent in a position the provider cannot invoke. Verify with the focused slash command search tests.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Warning Your free Security trial is over. An organization admin can activate Security or dismiss this notice. Comment |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a narrow web-composer bug fix that filters invalid skill suggestions only after the first prompt line, while preserving existing valid command behavior. The helper and focused tests are isolated, with no schema, infrastructure, security, billing, or default-setting changes. You can add or adjust custom eligibility rules. Learn more. |
## What's Changed * fix(server): skip IDE detection in Claude probes by @yashranaway in pingdotgg/t3code#8634 * chore(macroscope): review diagnostic overrides by @t3-code[bot] in pingdotgg/t3code#8917 * fix(contracts): accept CLI event origins by @nateEc in pingdotgg/t3code#8905 * fix(web): hide invalid slash skill completions by @nateEc in pingdotgg/t3code#8904 * fix(mobile): defer draft navigation until submission completes by @juliusmarminge in pingdotgg/t3code#8914 * chore: disable CodeRabbit review status by @juliusmarminge in pingdotgg/t3code#8933 * Delete app.json by @juliusmarminge in pingdotgg/t3code#8934 * fix(web): show scrollbar for wide markdown tables by @UtkarshUsername in pingdotgg/t3code#8868 * fix(mobile): shimmer active tool rows by @juliusmarminge in pingdotgg/t3code#8932 **Full Changelog**: pingdotgg/t3code@v0.0.38-nightly.20260831.1236...v0.0.38-nightly.20260831.1240 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.38-nightly.20260831.1240
Restores main features dropped by the policy replay: #8569 theme wiring, #8850 composer banner follow-ups, #8855/#8904 composer fixes, #8831 settings search rework, #8803 workspace-mutation refresh (v2-adapted), #8840 circle-alert, #8584 codex artifact templates, #8688/#8807/#8936 video + image previews (web and mobile, v2-adapted), #8862 Expo glass, and the round's docs. Timeline thinking rows (#8984) stay on the v2 work-live system. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fixes #8758.
The slash menu offered skills at the start of any line, even though providers can only invoke them when the command begins the full prompt. Selecting one in a later line silently produced a non-running command.
Filter skill entries from slash completion outside prompt position zero while keeping built-in and provider slash commands available there.
Verification:
vp fmt --checkand focused slash command search tests (7 passing).Model and harness: GPT-5 Codex via Codex CLI.
Note
Low Risk
Narrow UX fix to slash-completion filtering with no auth, data, or provider invocation changes beyond what users can already type.
Overview
Fixes invalid skill suggestions in the composer slash menu when
/is typed on a later line of the message.Adds
slashCommandItemsForPromptPosition, which dropsskill-typed menu entries unless the slash trigger is at prompt offset zero (composerTrigger.rangeStart === 0). Built-in and provider slash commands still appear on any line.ChatComposerruns the combined slash list through this filter beforesearchSlashCommandItems.Tests cover that skills remain at prompt start and are omitted when
isAtPromptStartis false.Reviewed by Cursor Bugbot for commit caa9777. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Hide skill items from slash command completions unless cursor is at prompt start
slashCommandItemsForPromptPositionto filter outskill-type items when the cursor is not at position 0 in composerSlashCommandSearch.tsChatComposernow wraps the combined built-in, provider, and skill item list with this function before searching, passingcomposerTrigger.rangeStart === 0as the start flagskillitems are filtered by position; if other item types should also be position-sensitive, they are unaffectedMacroscope summarized caa9777.