test: remove static presentation snapshots - #9008
Conversation
There was a problem hiding this comment.
This PR only deletes tests. Four of the removed web suites are not static presentation snapshots — they pin interaction/state/selector-ownership contracts that this codebase has regressed on before (disabled-control tooltips, the contrast-era --control-icon-color indirection, command inset selector ownership, unfocused address-bar value). Removing them leaves those contracts unguarded with no replacement coverage in the PR. apps/web/src/components/ui/menu.test.tsx is a pure class-string snapshot and is reasonable to prune.
Posted via Macroscope — UI Consistency
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This PR removes two test-only presentation checks and does not modify production code, configuration, product defaults, or customer-request behavior. Its impact is limited to reducing test coverage in the affected areas. Notes:
You can add or adjust custom eligibility rules. Learn more. |
## What's Changed * fix(client): use package import for markdown image helpers by @juliusmarminge in pingdotgg/t3code#9010 * test: remove static presentation snapshots by @t3-code[bot] in pingdotgg/t3code#9008 * perf(server): bound snapshot activity payload memory by @t3dotgg in pingdotgg/t3code#9000 * perf(server): cut idle CPU use and stop provider event leaks by @t3dotgg in pingdotgg/t3code#8187 **Full Changelog**: pingdotgg/t3code@v0.0.38-nightly.20260901.1244...v0.0.38-nightly.20260901.1245 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.38-nightly.20260901.1245
problem
these two test files only maintained snapshots of source literals. they would fail on intentional presentation edits and be updated alongside the implementation without protecting behavior.
removal evidence
apps/web/src/components/ui/menu.test.tsxserver-renderedMenuRadioItemonly to check the literal-mx-0.5utility already declared directly on that component. it exercised no menu interaction, state, geometry, or layout measurement.apps/mobile/src/lib/typography.test.tsrestated arbitrary values fromMOBILE_TYPOGRAPHYandMOBILE_CODE_SURFACE. the production derivations remain covered byappearancePreferences.test.ts, including the 16pt default, authored scale variables, and code-surface geometry.four initially considered web suites were retained after review confirmed they protect selector ownership, semantic contrast, disabled-control tooltips, and address-bar state.
verification
git diff --checkpassedopenai gpt-5.6-sol via hermes agent
Note
Low Risk
Test-only deletion with no production code changes; remaining targeted suites still pass per PR verification.
Overview
Deletes
apps/mobile/src/lib/typography.test.tsandapps/web/src/components/ui/menu.test.tsx, which only asserted fixed literals (font scale numbers,MOBILE_CODE_SURFACEfields, and the-mx-0.5class on menu radio items) via static markup or object equality.Those checks duplicated implementation details and would break on intentional styling tweaks without guarding interaction, layout, or preference resolution. Mobile typography and code-surface behavior stay covered elsewhere (e.g. appearance preference tests); other web UI suites that assert selector ownership, contrast, tooltips, and address-bar behavior are unchanged.
Reviewed by Cursor Bugbot for commit 7bf34d7. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Remove static presentation snapshot tests for typography and menu
Deletes typography.test.ts and menu.test.tsx, which asserted on hardcoded presentation values such as the MOBILE_TYPOGRAPHY scale and the
-mx-0.5class on radio menu items.Macroscope summarized 7bf34d7.