You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(client-runtime): subagent previews no longer end in a broken character - #30391
subagentDetailPreview in packages/client-runtime/src/state/subagentDisplay.ts builds a one-line preview of a subagent's progress or result. It trims leading whitespace, collapses whitespace runs, and cuts anything longer than 280 UTF-16 code units at 280 code units, then adds …. When an emoji straddles that cut, the slice keeps only the emoji's high surrogate (U+D83D for 😀). The preview then ends in a replacement character (�) right before the …, where it should end on the last whole character before the emoji.
Where the broken end shows:
Web, the subagent hover card (SubagentTooltipContent). It shows the preview through MiddleTruncate, which always keeps the last 10 code points in a shrink-0 span, so the � stays visible. The card opens from subagent rows in the chat timeline (V2LifecycleRow), the thread relationships panel (ThreadRelationshipsControl), workflow member rows (ThreadLineageWorkflowRow) and the workflow opening block (WorkflowOpeningBlock).
Where it is clipped, so it looks the same before and after this fix:
Mobile, Agents sheet, workflow member cards: the detail line is numberOfLines={1} (ThreadWorkflowGroup.tsx), so its end never shows.
Mobile, Agents sheet, subagent rows: the detail line is numberOfLines={3} (SubagentRow.tsx). Its end shows only when the whole preview fits in three lines, which takes over 90 characters per line, so not on a phone.
Expected: the cut never splits a surrogate pair, as in the context chip labels #29158 fixed.
Change
When the 280-code-unit cut would land between a high and a low surrogate, it steps back one code unit, so the emoji is dropped whole. This is the same check #29158 added to context chip labels and #29563 added to t3 thread start titles. The 280-code-unit limit, the whitespace collapsing, the … suffix and every preview that does not split a pair are unchanged.
The cut still works per code point, not per grapheme cluster. A multi-code-point emoji, such as a flag, a skin-tone modifier or a ZWJ family, can still be split between its code points. It never leaves a lone surrogate. That matches the precedents.
The existing test already had a case with an emoji on the cut, added by perf PR #21277, and it expected the lone high surrogate. That was pinned old behaviour, not a choice. #21277's body says: "Selection priority, whitespace collapsing, trailing-space handling, ellipsis, null fallback, and the existing UTF-16 truncation boundary are retained." Its goal was output equal to the old code's, so it pinned the split. The case now expects the emoji dropped whole.
The shared truncate in packages/shared is not used here. #24611 (open) fixes the same split in it, but this function does not call it, and its arithmetic differs: it trims, cuts at the limit and adds ... (three dots), while this preview keeps its own whitespace handling and adds … (one character), so switching would change the preview's text and length.
Scope and approval
This is a very small, focused fix for an obvious bug, so there is no prior issue. It is the defect #29158 ("context chip labels no longer split an emoji at the 200-character cap") and #29563 ("t3 thread start titles no longer end in a broken character") fixed elsewhere, still present in the shared subagent preview. It applies their check and changes no other behaviour, setting or contract.
Overlap check, by subagentDetailPreview and by file. #17420, #21643 and #27034 touch subagentDisplay.ts, but none changes subagentDetailPreview's cut. #29637 changes how the timeline row cleans a subagent preview, in V2LifecycleRow.logic.ts, not this cut. #24611 changes the shared truncate, which this function does not call.
Verification
packages/client-runtime/src/state/subagentDisplay.test.ts already projects a failed subagent whose result is 279 ASCII characters followed by 😀, so the emoji sits on the cut. Its expected value changes from the 279 characters, the lone high surrogate U+D83D and … to the 279 characters and ….
On main with only the test commit (d79b414), from packages/client-runtime, vp test run src/state/subagentDisplay.test.ts:
FAIL src/state/subagentDisplay.test.ts > normalizes Unicode whitespace and ignores a large hidden suffix
Tests 1 failed | 4 passed (5)
In words: on main the preview is the 279 ASCII characters, the lone high surrogate U+D83D, then …. With the fix it is the 279 ASCII characters, then ….
With the fix:
vp test run src/state/subagentDisplay.test.ts in packages/client-runtime: 5 passed.
vp run check:changed from the repo root: format, lint, knip, typecheck (7 packages) and tests (2 files) all pass.
To see it on web: in a thread whose agent ran a subagent, let the subagent report a result longer than 280 characters whose first 279 characters are ASCII with no whitespace runs, followed by an emoji and more text. The preview trims leading whitespace and collapses whitespace runs before it counts, so count after that. Hover the subagent's row in the chat timeline. On main the hover card's preview line ends in � before the …. With the fix it ends in ….
What I could not check: the hover card in a running app. The test covers the preview function every surface above renders.
Bug: a subagent preview ends in a broken character when an emoji sits at the 280-unit cut
This was written with Claude Opus 5.5 in Claude Code, driven from T3 Code.
…acter
A subagent's progress or result preview is cut at 280 UTF-16 code units
with "…" added. When an emoji straddled the cut, the preview kept only its
high surrogate and showed a replacement character before the "…". The
web subagent hover cards show the end of that preview.
The cut now steps back one unit when it would land between a high and a
low surrogate, the same check pingdotgg#29158 added to context chip labels and
pingdotgg#29563 added to thread titles. The existing test had pinned the split
half; it now expects the emoji dropped whole.
Bug: a subagent preview ends in a broken character when an emoji sits at the 280-unit cut
Macroscope's review found this PR approvable — Subagent previews avoid ending with half an emoji when truncated. The change is limited to display formatting, with no changes to stored data, product defaults, or external systems.
You can add or adjust custom eligibility rules. Learn more.
No actionable comments were generated in the recent review.
Walkthrough
subagentDetailPreview now avoids splitting a UTF-16 surrogate pair at its 280-code-unit cutoff. The test expects the preview to end after 279 x characters, followed by an ellipsis.
When the cutoff splits a surrogate pair, subagentDetailPreview shortens the slice by one code unit. The test expects the ellipsis to follow 279 x characters.
No merge-blocking issue was identified in the Unicode preview fix.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title clearly and concisely describes the main change: preventing broken characters in subagent previews.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Description check
The pull request follows the required structure. It clearly describes the problem, expected behavior, implementation, scope rationale, overlap review, focused tests, broader validation, manual verific…
Full details: Description check
Explanation
The pull request follows the required structure. It clearly describes the problem, expected behavior, implementation, scope rationale, overlap review, focused tests, broader validation, manual verification steps, and the unverified running-app check. It also includes the model and harness used.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
CodeRabbit Verify
Run CodeRabbit Verify to test the changes in this pull request.
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review.
Verified unchanged head adf15a992b86fc7d9ecd9c2187305986dae0b9aa on a Linux Boat VM using repository Playwright and /usr/bin/google-chrome.
Ran vp i and vp run dev on github/main (2f8de8d7bf) in a separate worktree. Created a project through the web app pointing at a real git repository, then sent real Codex gpt-6.1-sol turns that spawned native subagents. No mocks, replay provider, fixtures, or fabricated database rows were used.
A child returned 279 ASCII x characters followed by 😀 boundary-tail. Main's completed-subagent hover card retained U+D83D before the ellipsis and visibly showed a broken character. Stopped main before starting the exact PR head in isolated state. Copied only the stopped, app-created database for matching before/after data. The same hover card on this head ends cleanly with the ellipsis.
Also ran a fresh Codex parent/child turn on the PR head and checked the rendered preview text:
fresh boundary preview: 279 x characters + …; length 280
lone surrogate: false; replacement character: false
short emoji preview: short result 😀 intact
long ASCII preview: 280 a characters + …; length 281
relationships panel hover: same clean boundary preview
open child: full 279 x characters + 😀 boundary-tail visible
open parent: returned to parent conversation
The local proxy retried during two turns and recovered; all requested results completed. The fresh PR parent turn finished in 2m 20s.
Blacksmith passed the existing subagentDisplay.test.ts tests (5/5) and vp run check:changed against the PR base: format, lint, knip, seven-package typecheck, and focused tests. The shallow worker needed its comparison ancestry restored first. No source changes were needed. The PR currently reports 30 successful checks.
Before, main:
After, same app-created result on the PR:
Fresh PR turn, opening the hover card:
Inspected the captures and checked uploaded video playback and seeking in T3's browser.
Not verified
Native iOS/Android and the Electron shell were not exercised on this Linux web run. Other providers, workflow-specific hover entry points, and remote/tunnel connections were not exercised. Grapheme-cluster preservation is outside this change; this verifies surrogate-pair safety at the specified boundary.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:S10-29 changed lines (additions + deletions).vouch:unvouchedPR author is not yet trusted in the VOUCHED list.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
Bot
added
vouch:unvouched
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
Problem
subagentDetailPreviewinpackages/client-runtime/src/state/subagentDisplay.tsbuilds a one-line preview of a subagent's progress or result. It trims leading whitespace, collapses whitespace runs, and cuts anything longer than 280 UTF-16 code units at 280 code units, then adds…. When an emoji straddles that cut, the slice keeps only the emoji's high surrogate (U+D83D for 😀). The preview then ends in a replacement character (�) right before the…, where it should end on the last whole character before the emoji.Where the broken end shows:
SubagentTooltipContent). It shows the preview throughMiddleTruncate, which always keeps the last 10 code points in ashrink-0span, so the � stays visible. The card opens from subagent rows in the chat timeline (V2LifecycleRow), the thread relationships panel (ThreadRelationshipsControl), workflow member rows (ThreadLineageWorkflowRow) and the workflow opening block (WorkflowOpeningBlock).Where it is clipped, so it looks the same before and after this fix:
numberOfLines={1}(ThreadWorkflowGroup.tsx), so its end never shows.numberOfLines={3}(SubagentRow.tsx). Its end shows only when the whole preview fits in three lines, which takes over 90 characters per line, so not on a phone.Expected: the cut never splits a surrogate pair, as in the context chip labels #29158 fixed.
Change
When the 280-code-unit cut would land between a high and a low surrogate, it steps back one code unit, so the emoji is dropped whole. This is the same check #29158 added to context chip labels and #29563 added to
t3 thread starttitles. The 280-code-unit limit, the whitespace collapsing, the…suffix and every preview that does not split a pair are unchanged.The cut still works per code point, not per grapheme cluster. A multi-code-point emoji, such as a flag, a skin-tone modifier or a ZWJ family, can still be split between its code points. It never leaves a lone surrogate. That matches the precedents.
The existing test already had a case with an emoji on the cut, added by perf PR #21277, and it expected the lone high surrogate. That was pinned old behaviour, not a choice. #21277's body says: "Selection priority, whitespace collapsing, trailing-space handling, ellipsis, null fallback, and the existing UTF-16 truncation boundary are retained." Its goal was output equal to the old code's, so it pinned the split. The case now expects the emoji dropped whole.
The shared
truncateinpackages/sharedis not used here. #24611 (open) fixes the same split in it, but this function does not call it, and its arithmetic differs: it trims, cuts at the limit and adds...(three dots), while this preview keeps its own whitespace handling and adds…(one character), so switching would change the preview's text and length.Scope and approval
This is a very small, focused fix for an obvious bug, so there is no prior issue. It is the defect #29158 ("context chip labels no longer split an emoji at the 200-character cap") and #29563 ("t3 thread start titles no longer end in a broken character") fixed elsewhere, still present in the shared subagent preview. It applies their check and changes no other behaviour, setting or contract.
Overlap check, by
subagentDetailPreviewand by file. #17420, #21643 and #27034 touchsubagentDisplay.ts, but none changessubagentDetailPreview's cut. #29637 changes how the timeline row cleans a subagent preview, inV2LifecycleRow.logic.ts, not this cut. #24611 changes the sharedtruncate, which this function does not call.Verification
packages/client-runtime/src/state/subagentDisplay.test.tsalready projects a failed subagent whose result is 279 ASCII characters followed by😀, so the emoji sits on the cut. Its expected value changes from the 279 characters, the lone high surrogate U+D83D and…to the 279 characters and….On
mainwith only the test commit (d79b414), frompackages/client-runtime,vp test run src/state/subagentDisplay.test.ts:In words: on
mainthe preview is the 279 ASCII characters, the lone high surrogate U+D83D, then…. With the fix it is the 279 ASCII characters, then….With the fix:
vp test run src/state/subagentDisplay.test.tsinpackages/client-runtime: 5 passed.vp run check:changedfrom the repo root: format, lint, knip, typecheck (7 packages) and tests (2 files) all pass.To see it on web: in a thread whose agent ran a subagent, let the subagent report a result longer than 280 characters whose first 279 characters are ASCII with no whitespace runs, followed by an emoji and more text. The preview trims leading whitespace and collapses whitespace runs before it counts, so count after that. Hover the subagent's row in the chat timeline. On
mainthe hover card's preview line ends in � before the…. With the fix it ends in….What I could not check: the hover card in a running app. The test covers the preview function every surface above renders.
Bug: a subagent preview ends in a broken character when an emoji sits at the 280-unit cut
This was written with Claude Opus 5.5 in Claude Code, driven from T3 Code.