Skip to content

fix(server): Pi transcripts carry their home path - #28061

Merged
maria-rcks merged 1 commit into
mainfrom
fix/pi-transcript-home-path
Oct 31, 2026
Merged

maria-rcks merged 1 commit into
mainfrom
fix/pi-transcript-home-path

Conversation

@maria-rcks

Copy link
Copy Markdown
Collaborator

main fails typecheck since #24982: it made homePath required on transcript candidates, and the Pi session discovery from #27515 still builds candidates without it (AgentSessionScanner.ts:1203, TS2741). Every CI run on main since then fails Build and Typecheck.

Pi candidates now pass homePath: sessionsDir. For Pi the resolved home path is the sessions directory (resolvePiSessionsDir), and homePath is only read for Codex thread names, so Pi behavior is unchanged.

Checked: vp run typecheck passes for the whole repo, and AgentSessionScanner.test.ts passes (54 tests).

Written by Claude Opus 5.5 in Claude Code on behalf of Maria.

🤖 Generated with Claude Code

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 31, 2026
@macroscopeapp

macroscopeapp Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 7d19258

Macroscope's review found this PR approvable — Pi transcript candidates now carry their existing sessions directory as home-path metadata. This narrowly scoped change leaves discovery scope and product defaults unchanged.

You can add or adjust custom eligibility rules. Learn more.

@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ The exact PR base did not have a successful artifact. Baseline uses the latest successful main measurement shown below.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.0 KiB 5.0 KiB 0 B (0.0%) 6.8 KiB ✅
Codex Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.2 KiB 1.2 KiB 0 B (0.0%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 21.6 KiB 21.6 KiB 0 B (0.0%) 24.4 KiB ✅
Codex Live turn messages 2 2 0 (0.0%) 8 ✅
Claude Total thread wire 5.0 KiB 5.0 KiB −29 B (−0.6%) 6.8 KiB ✅
Claude Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.3 KiB 1.2 KiB −29 B (−2.3%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 21.9 KiB 21.9 KiB −41 B (−0.2%) 24.4 KiB ✅
Claude Live turn messages 2 1 −1 (−50.0%) 8 ✅

Baseline: 80fd67e · PR result: 7d19258 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant